You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2025/02/07 04:17:34 UTC
[PR] Minor: remove unused index mod [datafusion]
zhuqi-lucas opened a new pull request, #14534:
URL: https://github.com/apache/datafusion/pull/14534
## Which issue does this PR close?
This is a minor change for remove unused file and mod.
## Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: deprecate unused index mod [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #14534:
URL: https://github.com/apache/datafusion/pull/14534#discussion_r1946069187
##########
datafusion/physical-plan/src/sorts/mod.rs:
##########
@@ -19,12 +19,9 @@
mod builder;
mod cursor;
-mod index;
mod merge;
pub mod partial_sort;
pub mod sort;
pub mod sort_preserving_merge;
mod stream;
pub mod streaming_merge;
-
-pub use index::RowIndex;
Review Comment:
cargo clippy -- -D dead_code
It seems it can detect the unused code, but we still use the struct in mod, so we can't detect those code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused index mod [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #14534:
URL: https://github.com/apache/datafusion/pull/14534#discussion_r1946040045
##########
datafusion/physical-plan/src/sorts/mod.rs:
##########
@@ -19,12 +19,9 @@
mod builder;
mod cursor;
-mod index;
mod merge;
pub mod partial_sort;
pub mod sort;
pub mod sort_preserving_merge;
mod stream;
pub mod streaming_merge;
-
-pub use index::RowIndex;
Review Comment:
Addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: deprecate unused index mod [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #14534:
URL: https://github.com/apache/datafusion/pull/14534#issuecomment-2642727842
Thanks @zhuqi-lucas @2010YOUY01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: deprecate unused index mod [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #14534:
URL: https://github.com/apache/datafusion/pull/14534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused index mod [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on code in PR #14534:
URL: https://github.com/apache/datafusion/pull/14534#discussion_r1945987503
##########
datafusion/physical-plan/src/sorts/mod.rs:
##########
@@ -19,12 +19,9 @@
mod builder;
mod cursor;
-mod index;
mod merge;
pub mod partial_sort;
pub mod sort;
pub mod sort_preserving_merge;
mod stream;
pub mod streaming_merge;
-
-pub use index::RowIndex;
Review Comment:
This is a public struct, we should deprecate it first https://datafusion.apache.org/library-user-guide/api-health.html
By the way, I'm curious is there a way we can detect such unused structs in CI 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused index mod [datafusion]
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #14534:
URL: https://github.com/apache/datafusion/pull/14534#discussion_r1946033818
##########
datafusion/physical-plan/src/sorts/mod.rs:
##########
@@ -19,12 +19,9 @@
mod builder;
mod cursor;
-mod index;
mod merge;
pub mod partial_sort;
pub mod sort;
pub mod sort_preserving_merge;
mod stream;
pub mod streaming_merge;
-
-pub use index::RowIndex;
Review Comment:
Thank you @2010YOUY01 for review, this is a good point if we can detect such unused structs in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org