You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/20 03:41:59 UTC
Review Request 64733: Fixed conversion warnings in tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
Repository: mesos
Description
-------
Stringified a `size_t` for `http::Request.headers` value.
The types in `metrics_tests.cpp` were defined as `double`, and so should
be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4
3rdparty/libprocess/src/tests/metrics_tests.cpp bb7c9e37e5576f5b2e3ecc1a215e1edac758b254
Diff: https://reviews.apache.org/r/64733/diff/1/
Testing
-------
These are in libprocess.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64733: Fixed conversion warnings in tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/
-----------------------------------------------------------
(Updated Jan. 9, 2018, 11:08 a.m.)
Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Stringified a `size_t` for `http::Request.headers` value.
The types in `metrics_tests.cpp` were defined as `double`, and so should
be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4
3rdparty/libprocess/src/tests/metrics_tests.cpp 5f7117e4ee404643b4d784cd5f0308ee23f097cb
Diff: https://reviews.apache.org/r/64733/diff/3/
Changes: https://reviews.apache.org/r/64733/diff/2-3/
Testing
-------
These are in libprocess.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64733: Fixed conversion warnings in tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/#review194914
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Jan. 5, 2018, 1:54 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64733/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 1:54 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Stringified a `size_t` for `http::Request.headers` value.
>
> The types in `metrics_tests.cpp` were defined as `double`, and so should
> be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4
> 3rdparty/libprocess/src/tests/metrics_tests.cpp bb7c9e37e5576f5b2e3ecc1a215e1edac758b254
>
>
> Diff: https://reviews.apache.org/r/64733/diff/2/
>
>
> Testing
> -------
>
> These are in libprocess.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64733: Fixed conversion warnings in tests.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/
-----------------------------------------------------------
(Updated Jan. 5, 2018, 1:54 p.m.)
Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Stringified a `size_t` for `http::Request.headers` value.
The types in `metrics_tests.cpp` were defined as `double`, and so should
be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4
3rdparty/libprocess/src/tests/metrics_tests.cpp bb7c9e37e5576f5b2e3ecc1a215e1edac758b254
Diff: https://reviews.apache.org/r/64733/diff/2/
Changes: https://reviews.apache.org/r/64733/diff/1-2/
Testing
-------
These are in libprocess.
Thanks,
Andrew Schwartzmeyer