You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/28 11:16:37 UTC

[GitHub] [flink] rkhachatryan commented on a change in pull request #18552: [FLINK-25479][rpc] Serialize TaskStateSnapshot when sending to JM from TM

rkhachatryan commented on a change in pull request #18552:
URL: https://github.com/apache/flink/pull/18552#discussion_r794414419



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/utils/TestingJobMasterGateway.java
##########
@@ -436,10 +438,18 @@ public void acknowledgeCheckpoint(
             ExecutionAttemptID executionAttemptID,
             long checkpointId,
             CheckpointMetrics checkpointMetrics,
-            TaskStateSnapshot subtaskState) {
+            SerializedValue<TaskStateSnapshot> subtaskState) {
+        TaskStateSnapshot snapshot;
+        try {
+            snapshot =
+                    subtaskState == null
+                            ? null
+                            : subtaskState.deserializeValue(ClassLoader.getSystemClassLoader());

Review comment:
       Good point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org