You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/09/11 21:09:33 UTC
[GitHub] [groovy] tosts opened a new pull request #1366: Character filter for MarkupBuilder
tosts opened a new pull request #1366:
URL: https://github.com/apache/groovy/pull/1366
Could this work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] tosts commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
tosts commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-694366232
Great! \o/
@Surrogates: No, as a default for writing HTML that's probably even desirable.
They just live in the intenional limbo of no MUST in XML, but not discouraged either.
Ha, and you caught me. I copy-pasted a bit too much on my explanatory comments.
Let met fix that real quick...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] tosts commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
tosts commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-691848682
Also: Not sure what I should do about a timeout in the sonar checks. Does that have something to do with me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] tosts commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
tosts commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-693536478
Like so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-693655815
It's been a while since I delved into XML encoding rules. We take a slightly different approach for surrogates (potentially writing them as hex strings) in StreamingMarkupWriter:
https://github.com/apache/groovy/blob/master/subprojects/groovy-xml/src/main/java/groovy/xml/streamingmarkupsupport/StreamingMarkupWriter.java#L141-L170
Do you see anything wrong with that approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1366:
URL: https://github.com/apache/groovy/pull/1366
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-693216686
Parts of this look good but we can possibly re-work to increase the likelihood of being able to extend to `StreamingMarkupBuilder`. I'll take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-694235526
Merged with a few changes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] tosts commented on pull request #1366: Character filter for MarkupBuilder
Posted by GitBox <gi...@apache.org>.
tosts commented on pull request #1366:
URL: https://github.com/apache/groovy/pull/1366#issuecomment-694375987
Over here: https://github.com/apache/groovy/pull/1372
Sorry for the extra round-trip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org