You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2017/12/21 17:47:34 UTC
[GitHub] nifi-minifi-cpp pull request #226: MINIFICPP-331 Implemented string replacem...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/226
MINIFICPP-331 Implemented string replacement functions
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-331
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 1cfa0181c7a1ad4f26fb06cc554e76b57c91039c
Author: Andy I. Christianson <an...@...>
Date: 2017-12-21T17:46:36Z
MINIFICPP-331 Implemented string replacement functions
----
---
[GitHub] nifi-minifi-cpp issue #226: MINIFICPP-331 Implemented string replacement fun...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/226
Looks like the 4.8.5 version doesn't have complete support for that level of regex. I'm assuming we don't want to add BOOST, either, so we may not be able to support certain regex types on old GCC.
---
[GitHub] nifi-minifi-cpp pull request #226: MINIFICPP-331 Implemented string replacem...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/226
---
[GitHub] nifi-minifi-cpp issue #226: MINIFICPP-331 Implemented string replacement fun...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/226
@phrocker ready for re-review.
---
[GitHub] nifi-minifi-cpp issue #226: MINIFICPP-331 Implemented string replacement fun...
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/226
Put in blacklist of GCC < 4.9.0 for EL regex functions. Will add this limitation/caveat to the minificpp EL docs (to be added with MINIFICPP-366).
---
[GitHub] nifi-minifi-cpp issue #226: MINIFICPP-331 Implemented string replacement fun...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/226
@achristianson Seems good. It looks like the failing build succeeded. Thanks
---