You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2017/05/10 21:42:33 UTC

[12/50] [abbrv] lucene-solr:jira/solr-10290: SOLR-10636 Increase randomness of metric names to avoid conflicts with non-test scopes.

SOLR-10636 Increase randomness of metric names to avoid conflicts with
non-test scopes.


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/69783f64
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/69783f64
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/69783f64

Branch: refs/heads/jira/solr-10290
Commit: 69783f6403b01c4358578344801c5133ce0b812d
Parents: b1efd37
Author: Andrzej Bialecki <ab...@apache.org>
Authored: Wed May 10 17:44:19 2017 +0200
Committer: Andrzej Bialecki <ab...@apache.org>
Committed: Wed May 10 17:45:42 2017 +0200

----------------------------------------------------------------------
 .../src/test/org/apache/solr/metrics/SolrMetricTestUtils.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/69783f64/solr/core/src/test/org/apache/solr/metrics/SolrMetricTestUtils.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/metrics/SolrMetricTestUtils.java b/solr/core/src/test/org/apache/solr/metrics/SolrMetricTestUtils.java
index 98fc9b1..c506c1d 100644
--- a/solr/core/src/test/org/apache/solr/metrics/SolrMetricTestUtils.java
+++ b/solr/core/src/test/org/apache/solr/metrics/SolrMetricTestUtils.java
@@ -35,7 +35,7 @@ public final class SolrMetricTestUtils {
   }
 
   public static String getRandomScope(Random random, boolean shouldDefineScope) {
-    return shouldDefineScope ? TestUtil.randomSimpleString(random, 1, 10) : null; // must be simple string for JMX publishing
+    return shouldDefineScope ? TestUtil.randomSimpleString(random, 5, 10) : null; // must be simple string for JMX publishing
   }
 
   public static SolrInfoBean.Category getRandomCategory(Random random) {
@@ -65,7 +65,7 @@ public final class SolrMetricTestUtils {
       boolean shouldReplaceMetric = !existing.isEmpty() && random.nextBoolean();
       String name = shouldReplaceMetric
           ? existingKeys.get(TestUtil.nextInt(random, 0, existingKeys.size() - 1))
-          : TestUtil.randomSimpleString(random, 1, 10) + SUFFIX; // must be simple string for JMX publishing
+          : TestUtil.randomSimpleString(random, 5, 10) + SUFFIX; // must be simple string for JMX publishing
 
       Counter counter = new Counter();
       counter.inc(random.nextLong());