You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "chengzhanli (via GitHub)" <gi...@apache.org> on 2024/11/27 06:11:26 UTC

[PR] feat(grid): enhance `grid.containLabel` [echarts]

chengzhanli opened a new pull request, #20542:
URL: https://github.com/apache/echarts/pull/20542

   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Enhances the `grid.containLabel` property in ECharts to allow specifying the direction (`horizontal` or `vertical`) for label containment.
   
   ### Fixed issues
   
   [#20540](https://github.com/apache/echarts/issues/20540)
   
   ## Details
   
   ### Before: What was the problem?
   
   The `grid.containLabel` property was a simple boolean flag, which only enabled or disabled label containment. It lacked granularity, making it difficult to handle specific directions (e.g., only horizontal or vertical).
   
   ### After: How does it behave after the fixing?
   
   The `grid.containLabel` property now supports specifying the direction (`horizontal` or `vertical`) for label containment. This allows more precise control over grid size adjustments based on axis labels.Ï
   
   ## Document Info
   
   One of the following should be checked.
   
   - [ ] This PR doesn't relate to document changes
   - [x] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(grid): enhance `grid.containLabel` [echarts]

Posted by "chengzhanli (via GitHub)" <gi...@apache.org>.
chengzhanli commented on PR #20542:
URL: https://github.com/apache/echarts/pull/20542#issuecomment-2736357701

   Test file has been commit :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

Re: [PR] feat(grid): enhance `grid.containLabel` [echarts]

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #20542:
URL: https://github.com/apache/echarts/pull/20542#issuecomment-2502989232

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org