You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/08/10 17:29:30 UTC
[GitHub] flink pull request #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/2352
[FLINK-4370] Add an IntelliJ Inspections Profile
This adds an IntelliJ inspections profile for Flink in the `.idea` folder.
When the code is imported into IntelliJ, it should automatically pick up and use that inspection profile.
The profile adds some extra warnings and errors that I found useful in the past.
We should gradually activate more inspections (or deactivate some) as we feel it helps the development.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink inspections
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2352
----
commit e25e9ef6ac91dc5936d92212c74f96137646a0d1
Author: Stephan Ewen <se...@apache.org>
Date: 2016-08-10T17:21:28Z
[FLINK-4370] Add an IntelliJ Inspections Profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/2352
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2352
Okay, I see, it is not that easy with ignored files ;-)
Let me close this pull request and see if I can find another way to share these inspections automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2352
Should this be part of the repository? I think that IDE specific settings should be configured by the individual developers themselves and should remain local. However, I think that adding this profile to the flink website as a recommendation for IntelliJ is a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2352
This is only a suggestion. I thought it would be great to have a more unified set of warnings and errors, because it would encourage a more unified code style.
With this change, most IDE specific settings are still up to the user. This only sets a project-default set of inspections/warnings to display in the editor.
Changes to `.idea` are generally ignored - these files are an exception (they were "force added").
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2352
Agree with @tillrohrmann . And I'm confused that can it work? As `.idea` folder is in `.gitignore` list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2352
@StephanEwen can these be shared under `tools/idea/...`? If they are installed by default then any user modifications will be noted by git. Conversely, most contributors won't notice these files or synchronize as additional inspections are enabled, but as of now developers are on their own.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2352
Try to pull this patch and the following error occurred
```
$ git pull https://github.com/StephanEwen/incubator-flink inspections
From https://github.com/StephanEwen/incubator-flink
* branch inspections -> FETCH_HEAD
error: The following untracked working tree files would be overwritten by merge:
.idea/inspectionProfiles/Project_Default.xml
.idea/inspectionProfiles/profiles_settings.xml
Please move or remove them before you can merge.
Aborting
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2352
@greghogan That could definitely be done.
I was initially trying to do a trick: Check in the inspection profile that we want (in terms of what qualifies as a warning) but also add it to .gitignore so that any customization on a developer's end is not committed back.
That way we would set up everyone with the common base and still allow for customization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---