You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/16 02:55:31 UTC
[PR] Rename JsonUtils to JsonEngine [shardingsphere]
terrymanu opened a new pull request, #39475:
URL: https://github.com/apache/shardingsphere/pull/39475
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename JsonUtils to JsonEngine [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39475:
URL: https://github.com/apache/shardingsphere/pull/39475#issuecomment-5305431559
### Result
**Review Result: Mergeable**
The rename is complete and behavior-preserving. All 33 changed files consistently use `JsonEngine`, with no remaining `JsonUtils` references.
### Evidence
- [PR #39475](https://github.com/apache/shardingsphere/pull/39475), head `33fe781fda8b28611a1eac04faea36478123722b`
- Repository-wide reference search found zero stale `JsonUtils` references.
- Diff normalization shows only identifier, import, test-class, and Javadoc renames.
- Whitespace validation passed.
### Coverage
Reviewed the complete GitHub file list: 33 files, matching the local triple-dot diff from base `34e2ef5f78d84ba3b1164b4c76dfc03567492b53`.
Behavior cluster reviewed: JSON utility rename, production call sites, and corresponding unit/E2E tests.
Completed root-cause, blast-radius, tests/runtime, and convergence passes. No unresolved code-correctness gaps remain. This is a code-scope result; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename JsonUtils to JsonEngine [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39475:
URL: https://github.com/apache/shardingsphere/pull/39475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org