You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/01 08:17:06 UTC
[GitHub] [incubator-nuttx] troyf7 opened a new pull request #4928: input/touchscreen: added touchscreen gesture
troyf7 opened a new pull request #4928:
URL: https://github.com/apache/incubator-nuttx/pull/4928
added touchscreen gesture
Signed-off-by: futerigele <fu...@xiaomi.com>
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4928: input/touchscreen: added touchscreen gesture
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4928:
URL: https://github.com/apache/incubator-nuttx/pull/4928#discussion_r760459989
##########
File path: include/nuttx/input/touchscreen.h
##########
@@ -95,6 +95,16 @@
#define TOUCH_POS_VALID (1 << 4) /* Hardware provided a valid X/Y position */
#define TOUCH_PRESSURE_VALID (1 << 5) /* Hardware provided a valid pressure */
#define TOUCH_SIZE_VALID (1 << 6) /* Hardware provided a valid H/W contact size */
+#define TOUCH_GESTURE_VALID (1 << 7) /* Hardware provided a valid gesture */
+
+/* These definitions for touch gesture */
Review comment:
These are definitions for touch gesture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4928: input/touchscreen: added touchscreen gesture
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4928:
URL: https://github.com/apache/incubator-nuttx/pull/4928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] troyf7 commented on a change in pull request #4928: input/touchscreen: added touchscreen gesture
Posted by GitBox <gi...@apache.org>.
troyf7 commented on a change in pull request #4928:
URL: https://github.com/apache/incubator-nuttx/pull/4928#discussion_r760793566
##########
File path: include/nuttx/input/touchscreen.h
##########
@@ -95,6 +95,16 @@
#define TOUCH_POS_VALID (1 << 4) /* Hardware provided a valid X/Y position */
#define TOUCH_PRESSURE_VALID (1 << 5) /* Hardware provided a valid pressure */
#define TOUCH_SIZE_VALID (1 << 6) /* Hardware provided a valid H/W contact size */
+#define TOUCH_GESTURE_VALID (1 << 7) /* Hardware provided a valid gesture */
+
+/* These definitions for touch gesture */
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4928: input/touchscreen: added touchscreen gesture
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4928:
URL: https://github.com/apache/incubator-nuttx/pull/4928#discussion_r760459989
##########
File path: include/nuttx/input/touchscreen.h
##########
@@ -95,6 +95,16 @@
#define TOUCH_POS_VALID (1 << 4) /* Hardware provided a valid X/Y position */
#define TOUCH_PRESSURE_VALID (1 << 5) /* Hardware provided a valid pressure */
#define TOUCH_SIZE_VALID (1 << 6) /* Hardware provided a valid H/W contact size */
+#define TOUCH_GESTURE_VALID (1 << 7) /* Hardware provided a valid gesture */
+
+/* These definitions for touch gesture */
Review comment:
There are definitions for touch gesture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org