You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cdfhuang <gi...@git.apache.org> on 2015/08/24 19:18:49 UTC
[GitHub] incubator-zeppelin pull request: Add ability to truncate displayed...
GitHub user cdfhuang opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/252
Add ability to truncate displayed results while exporting full results to S3
This is a feature I personally find useful and hopefully others feel the same way.
All the result of executing a paragraph must be rendered by the client brower's Javascript engine. But when the result is sufficiently large, the rendering takes a long time, or completely hangs, which makes inspecting the result very difficult. But It's useful to be able to retrieve the paragraph results regardless. This PR adds in two features that can help solve this problem. The first feature is an option is to truncate how many lines are stored in the note.json. With a small number of lines, it's possible to get a preview of large result sets, and not hang the Javascript rendering. The second feature is an option to store the entire result into S3 and expose a button that generates a pre-signed URL to download the file. So the user is still able to download larger results (say a couple hundred MB) and inspect it offline.
Feedbacks are welcome.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cdfhuang/incubator-zeppelin s3_export
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit d5c0bc82e89cb1981b33dc317b6e9c63f7cd3b2f
Author: Corey Huang <co...@gmail.com>
Date: 2015-08-24T17:02:33Z
Add ability to truncate displayed results while exporting full result to S3.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add ability to truncate displayed...
Posted by djoelz <gi...@git.apache.org>.
Github user djoelz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/252#issuecomment-136522007
While I think this is a useful feature, I dont like the coupling it has with AWS APIs. I would recommend you create an export interface and have different implementations that are coupled to particular file systems. Also please add unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add ability to truncate displayed...
Posted by cdfhuang <gi...@git.apache.org>.
Github user cdfhuang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/252#issuecomment-136532088
Thanks for the comments. They are good suggestions, so I'll try to find time to address both issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---