You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/20 05:56:25 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4838: Update
schema API to reload table on schema change when applicable
codecov-io commented on issue #4838: Update schema API to reload table on schema change when applicable
URL: https://github.com/apache/incubator-pinot/pull/4838#issuecomment-555851260
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=h1) Report
> Merging [#4838](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a9f659147ec44636138d14d07dbde74fd5ac337c?src=pr&el=desc) will **increase** coverage by `20.25%`.
> The diff coverage is `57.31%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4838 +/- ##
=============================================
+ Coverage 37.09% 57.35% +20.25%
- Complexity 0 4 +4
=============================================
Files 1214 1214
Lines 65567 65597 +30
Branches 9536 9548 +12
=============================================
+ Hits 24323 37621 +13298
+ Misses 39034 25143 -13891
- Partials 2210 2833 +623
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/pinot/controller/api/resources/TableViews.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1RhYmxlVmlld3MuamF2YQ==) | `95.12% <100%> (+95.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...api/resources/PinotTableConfigRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFibGVDb25maWdSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `27.84% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...main/java/org/apache/pinot/common/data/Schema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9TY2hlbWEuamF2YQ==) | `83.05% <100%> (+41.82%)` | `0 <0> (ø)` | :arrow_down: |
| [...ler/api/resources/PinotSegmentRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFJlc3RsZXRSZXNvdXJjZS5qYXZh) | `16.29% <28.57%> (-1.77%)` | `0 <0> (ø)` | |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `62.74% <43.24%> (+28.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/pinot/common/config/TableNameBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlTmFtZUJ1aWxkZXIuamF2YQ==) | `87.5% <66.66%> (-0.97%)` | `0 <0> (ø)` | |
| [...ller/api/resources/PinotSchemaRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2NoZW1hUmVzdGxldFJlc291cmNlLmphdmE=) | `39.18% <71.42%> (+14.86%)` | `0 <0> (ø)` | :arrow_down: |
| [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `25% <0%> (-56.25%)` | `0% <0%> (ø)` | |
| [...altime/ServerSegmentCompletionProtocolHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL3JlYWx0aW1lL1NlcnZlclNlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2xIYW5kbGVyLmphdmE=) | `35.11% <0%> (-15.27%)` | `0% <0%> (ø)` | |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `87.86% <0%> (-4.63%)` | `0% <0%> (ø)` | |
| ... and [602 more](https://codecov.io/gh/apache/incubator-pinot/pull/4838/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=footer). Last update [a9f6591...b9ef6f6](https://codecov.io/gh/apache/incubator-pinot/pull/4838?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org