[jira] [Commented] (BEAM-746) Stop using the Streaming Flag in BigQueryIO.Write

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570420#comment-15570420 ] 

ASF GitHub Bot commented on BEAM-746:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1091

    [BEAM-746] Choose BigQuery Write implementation based on Input PCollection

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Stop using PipelineOptions, and instead use the boundedness of the input
    to choose how to write to BigQuery. This means that runners that don't
    use the streaming flag still function appropriately.
    
    Fixes BEAM-746

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam bqwrite_unbounded

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1091.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1091
    
----
commit 48dceca7cb7affa6666ade60147f20e1913bbdee
Author: Thomas Groh <tg...@google.com>
Date:   2016-10-13T00:58:57Z

    Choose BigQuery Write implementation based on Input PCollection
    
    Stop using PipelineOptions, and instead use the boundedness of the input
    to choose how to write to BigQuery. This means that runners that don't
    use the streaming flag still function appropriately.
    
    Fixes BEAM-746

----


> Stop using the Streaming Flag in BigQueryIO.Write
> -------------------------------------------------
>
>                 Key: BEAM-746
>                 URL: https://issues.apache.org/jira/browse/BEAM-746
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>            Priority: Minor
>
> The choice of write PTransform should be based on the boundedness of the input PCollection, not a PipelineOption.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)