[GitHub] [helix] chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.

[GitBox <gi...@apache.org>]

chenboat edited a comment on issue #378: Make the reservoir used in ZkClientPathMonitor metric configurable.
URL: https://github.com/apache/helix/pull/378#issuecomment-519807855
 
 
   > @chenboat Please refer to HelixManagerProperties. We should be able to do something similar for the monitors.
   > 
   > Some background here. We used to use System Properties for these configurations. You can still find a lot of these usages in our code. But we are trying to migrate to a more flexible way. So I think HelixManagerProperties would be a good example.
   > 
   > Please let us know what's your preference.
   
   I used HelixUtil.getSystemPropertyAsLong() which takes the system properties. It seems more fit for this case. HelixManagerProperties does not expose static property field now and I do not find an easy way to use in the monitors Helix core has right now. I just sent the latest commit in PR.
   
   @jiajunwang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org