You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael Dodsworth (JIRA)" <ji...@apache.org> on 2012/05/18 04:36:15 UTC

[jira] [Created] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Michael Dodsworth created SOLR-3467:
---------------------------------------

             Summary: ExtendedDismax escaping is missing several reserved characters
                 Key: SOLR-3467
                 URL: https://issues.apache.org/jira/browse/SOLR-3467
             Project: Solr
          Issue Type: Bug
          Components: query parsers
    Affects Versions: 4.0
            Reporter: Michael Dodsworth
            Priority: Minor
             Fix For: 4.0


When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).

Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Affects Version/s:     (was: 4.0)
                       3.6
        Fix Version/s: 5.0
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Attachment: SOLR-3467.patch

Updated trunk patch with extended test and CHANGES entry. Looks good to me. Any other comments before commit?
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Michael Dodsworth (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402287#comment-13402287 ] 

Michael Dodsworth commented on SOLR-3467:
-----------------------------------------

Thank you, Jan.

>From what I can tell, '/' only became a reserved character since 4.0 - https://issues.apache.org/jira/browse/LUCENE-2604.
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 3.6.1, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Michael Dodsworth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dodsworth updated SOLR-3467:
------------------------------------

    Attachment:     (was: SOLR-3467.patch)
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl resolved SOLR-3467.
-------------------------------

    Resolution: Fixed

Checked in to trunk and 4.x
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402910#comment-13402910 ] 

Jan Høydahl commented on SOLR-3467:
-----------------------------------

Yea, I see that. Actually, I cannot get the test to fail, even with 3.6.0 - is there a better way to trigger the missing escaping of particularly '&', '\\' and '|' ? If not, then I cannot see a need for a 3.6.x patch.
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 3.6.1, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401430#comment-13401430 ] 

Jan Høydahl commented on SOLR-3467:
-----------------------------------

Great. Are you able to add a JUnit test which reproduces the bug and shows that it is fixed?
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Fix Version/s: 3.6.1
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 3.6.1, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Fix Version/s:     (was: 3.6.1)
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Attachment: SOLR-3467.patch

New patch which also uncomments partialEscape() which is dead code
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 3.6.1, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Michael Dodsworth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dodsworth updated SOLR-3467:
------------------------------------

    Attachment: SOLR-3467.patch
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Assigned] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl reassigned SOLR-3467:
---------------------------------

    Assignee: Jan Høydahl
    
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Jan Høydahl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-3467:
------------------------------

    Attachment: SOLR-3467-lucene_solr_3_6.patch

This was an easy backport for 3.6.1
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 3.6
>            Reporter: Michael Dodsworth
>            Assignee: Jan Høydahl
>            Priority: Minor
>             Fix For: 4.0, 3.6.1, 5.0
>
>         Attachments: SOLR-3467-lucene_solr_3_6.patch, SOLR-3467.patch, SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Michael Dodsworth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dodsworth updated SOLR-3467:
------------------------------------

    Attachment: SOLR-3467.patch
                SOLR-3467.patch

added test.

Thanks for looking at the patch.
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3467.patch, SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-3467) ExtendedDismax escaping is missing several reserved characters

Posted by "Michael Dodsworth (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400895#comment-13400895 ] 

Michael Dodsworth commented on SOLR-3467:
-----------------------------------------

all feedback/review comments welcome
                
> ExtendedDismax escaping is missing several reserved characters
> --------------------------------------------------------------
>
>                 Key: SOLR-3467
>                 URL: https://issues.apache.org/jira/browse/SOLR-3467
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3467.patch
>
>
> When edismax is unable to parse the original user query, it retries using an escaped version of that query (where all reserved chars have been escaped).
> Currently, the escaping done in {{splitIntoClauses}} appears to be missing several chars from {{QueryParserBase#escape(String)}}, namely {{'\\', '|', '&', '/'}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org