You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2007/03/19 22:43:32 UTC

[jira] Created: (WICKET-408) properties encoding

properties encoding
-------------------

                 Key: WICKET-408
                 URL: https://issues.apache.org/jira/browse/WICKET-408
             Project: Wicket
          Issue Type: Bug
          Components: wicket-examples
    Affects Versions: 1.3
            Reporter: Sven Meier
            Priority: Trivial
             Fix For: 1.3
         Attachments: examples-forminput-properties.diff

Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.

See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-408) properties encoding

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot resolved WICKET-408.
-----------------------------------------

    Resolution: Fixed

Fixed, thanks for your patch.  I also ran native2ascii to get rid of any encoding problem.  Please update your working copy and test whether it works for you.

> properties encoding
> -------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-408) forminput properties encoding for da_DK, de and pt_BR locales

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482593 ] 

Jean-Baptiste Quenot commented on WICKET-408:
---------------------------------------------

Portugues do Brazil fixed, was overwritten by the following change:
http://svn.apache.org/viewvc?view=rev&revision=514405

Thanks again!

> forminput properties encoding for da_DK, de and pt_BR locales
> -------------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-408) properties encoding

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482329 ] 

Jean-Baptiste Quenot commented on WICKET-408:
---------------------------------------------

You might consider using native2ascii program provided by the JDK to avoid any encoding at all.

See http://java.sun.com/j2se/1.4.2/docs/api/java/util/Properties.html

> properties encoding
> -------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-408) properties encoding

Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier updated WICKET-408:
------------------------------

    Attachment: examples-forminput-properties.diff

Patch.

> properties encoding
> -------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-408) properties encoding

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot reassigned WICKET-408:
-------------------------------------------

    Assignee: Jean-Baptiste Quenot

> properties encoding
> -------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-408) forminput properties encoding for da_DK and de locales

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-408:
----------------------------------------

    Summary: forminput properties encoding for da_DK and de locales  (was: properties encoding)

> forminput properties encoding for da_DK and de locales
> ------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-408) forminput properties encoding for da_DK, de and pt_BR locales

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-408:
----------------------------------------

    Summary: forminput properties encoding for da_DK, de and pt_BR locales  (was: forminput properties encoding for da_DK and de locales)

> forminput properties encoding for da_DK, de and pt_BR locales
> -------------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-408) forminput properties encoding for da_DK and de locales

Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482576 ] 

Sven Meier commented on WICKET-408:
-----------------------------------

This is still not completely right:

- '.settings\org.eclipse.core.resources.prefs' lists some old entries with wrong paths
- FormInput_de.properties and FormInput_da_DK.properties are still listed as having UTF-8 encoding.
Thus the next unlucky guy  who introduces some umlauts in these files will probably run into problems again because Eclipse will save these in two bytes unicodes
- FormInput_pt_BR.properies is explicitely listed as having ISO-8859-1, but the file is in UTF-8
Choose locale brazil and you'll see garbage characters
- most european umlauts fit nicely in ISO-8859-1, so no need to obscure these files with unicode escapes.

> forminput properties encoding for da_DK and de locales
> ------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-408) forminput properties encoding for da_DK, de and pt_BR locales

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot updated WICKET-408:
----------------------------------------

    Fix Version/s:     (was: trunk)
                   1.3.0-beta1

> forminput properties encoding for da_DK, de and pt_BR locales
> -------------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: trunk
>            Reporter: Sven Meier
>            Assignee: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3.0-beta1
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-408) forminput properties encoding for da_DK and de locales

Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482579 ] 

Jean-Baptiste Quenot commented on WICKET-408:
---------------------------------------------

The advantage of Unicode escapes is that you don't need to specify Eclipse settings.  Most people have their workspace in UTF-8 so will be breaking the properties as you mention.  That's why we should always prefer working with Unicode escapes.  I'll be looking at the "portugues do brazil" properties now.

> forminput properties encoding for da_DK and de locales
> ------------------------------------------------------
>
>                 Key: WICKET-408
>                 URL: https://issues.apache.org/jira/browse/WICKET-408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-examples
>    Affects Versions: 1.3
>            Reporter: Sven Meier
>         Assigned To: Jean-Baptiste Quenot
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: examples-forminput-properties.diff
>
>
> Wicket supports ISO-8895-1 encodings for property files only (i.e. the non-xml based ones). Therefor the property files in the forminput example should have the correct encoding - the output will look scrambled otherwise.
> See attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.