[PR] fix(camel-salesforce): bump cometd-java-client-version to 8.0.0.beta2 [CAMEL-20588] [camel]

["dclappert (via GitHub)" <gi...@apache.org>]

dclappert opened a new pull request, #13555:
URL: https://github.com/apache/camel/pull/13555

   # Description
   The Set-Cookie "Expires" cookie attribute is being incorrectly parsed by the version `8.0.0.beta1` `cometd-java-client-http-jetty` library. This results in the request headers growing indefinitely, eventually leading to a "java.lang.IllegalArgumentException: Request header too large" exception being thrown by Salesforce auth servers. This issue seems to have been resolved in `8.0.0.beta2` by this PR: https://github.com/cometd/cometd/pull/1631
   
   This issue resides in the `JettyHttpClientTransport`  class which is called from the  `SubscriptionHelper`, and stems from the use of the `HttpField.getValueList` method, which uses the `QuotedCSV` class that extends `QuotedCSVParser`. Unfortunately, `QuotedCSVParser` does not appropriately handle the "Expires" cookie attribute, and splits the [RFC6265](https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html#name-examples) compliant Expires date string incorrectly.
   
   Given the following [RFC6265](https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html#name-examples) compliant cookie, 
   `Set-Cookie: CookieConsentPolicy=0:1; path=/; expires=Wed, 19-Mar-2025 00:18:54 GMT; Max-Age=31536000; secure`
   the call to `HttpField.getValueList` will result in the cookie string being split into:
   - `CookieConsentPolicy=0:1; path=/; expires=Wed`
   - `19-Mar-2025 00:18:54 GMT; Max-Age=31536000; secure`
   
   `JettyHttpClientTransport` is called from `SubscriptionHelper`, see:
   ```
   public class JettyHttpClientTransport extends AbstractHttpClientTransport {
   ...
     @Override
     public boolean onHeader(Response response, HttpField field) {
         if (response.getStatus() == HttpStatus.OK_200) {
             HttpHeader header = field.getHeader();
             if (header == HttpHeader.SET_COOKIE || header == HttpHeader.SET_COOKIE2) {
                 // We do not allow cookies to be handled by HttpClient, since one
                 // HttpClient instance is shared by multiple BayeuxClient instances.
                 // Instead, we store the cookies in the BayeuxClient instance.
                 Map<String, List<String>> cookies = Map.of(field.getName(), field.getValueList());
                 storeCookies(cookieURI, cookies);
                 return false;
             }
         }
         return true;
     }
   ```
   
   # Target
   - camel-4.4.x
   
   # Tracking
   - https://issues.apache.org/jira/browse/CAMEL-20588
   
   # Apache Camel coding standards and style
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   - [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(camel-salesforce): bump cometd-java-client-version to 8.0.0.beta2 [CAMEL-20588] [camel]

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus merged PR #13555:
URL: https://github.com/apache/camel/pull/13555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(camel-salesforce): bump cometd-java-client-version to 8.0.0.beta2 [CAMEL-20588] [camel]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #13555:
URL: https://github.com/apache/camel/pull/13555#issuecomment-2010201081

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org