[jira] [Commented] (KAFKA-2394) Use RollingFileAppender by default in log4j.properties

["Gérald Quintana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795530#comment-15795530 ] 

Gérald Quintana commented on KAFKA-2394:
----------------------------------------

It would be great to be able to mix time based and size based rolling files and limit the number of files.

* Log4J v2 can do it: https://logging.apache.org/log4j/2.x/manual/appenders.html#Composite_Triggering_Policy
* Log4J v1 + Log4J extras can mostly do it: https://logging.apache.org/log4j/extras/apidocs/org/apache/log4j/rolling/package-summary.html
* Logback can also do it: http://logback.qos.ch/manual/appenders.html#SizeAndTimeBasedRollingPolicy

> Use RollingFileAppender by default in log4j.properties
> ------------------------------------------------------
>
>                 Key: KAFKA-2394
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2394
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Dustin Cote
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.11.0.0
>
>         Attachments: log4j.properties.patch
>
>
> The default log4j.properties bundled with Kafka uses ConsoleAppender and DailyRollingFileAppender, which offer no protection to users from spammy logging. In extreme cases (such as when issues like KAFKA-1461 are encountered), the logs can exhaust the local disk space. This could be a problem for Kafka adoption since new users are less likely to adjust the logging properties themselves, and are more likely to have configuration problems which result in log spam. 
> To fix this, we can use RollingFileAppender, which offers two settings for controlling the maximum space that log files will use.
> maxBackupIndex: how many backup files to retain
> maxFileSize: the max size of each log file
> One question is whether this change is a compatibility concern? The backup strategy and filenames used by RollingFileAppender are different from those used by DailyRollingFileAppender, so any tools which depend on the old format will break. If we think this is a serious problem, one solution would be to provide two versions of log4j.properties and add a flag to enable the new one. Another solution would be to include the RollingFileAppender configuration in the default log4j.properties, but commented out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)