You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/07 06:07:18 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8166:
[feature][dashboard] Show/hide filter indicator on the applicable charts
when filter options are open/close
codecov-io commented on issue #8166: [feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close
URL: https://github.com/apache/incubator-superset/pull/8166#issuecomment-529077558
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=h1) Report
> Merging [#8166](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/be33934b838f9fae097882d401c9473bfc2d124c?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `35.64%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8166 +/- ##
==========================================
- Coverage 66.18% 66.12% -0.06%
==========================================
Files 479 480 +1
Lines 22931 23010 +79
Branches 2524 2549 +25
==========================================
+ Hits 15176 15215 +39
- Misses 7621 7658 +37
- Partials 134 137 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9wcm9wU2hhcGVzLmpzeA==) | `100% <ø> (ø)` | :arrow_up: |
| [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9DaGFydC5qc3g=) | `91.66% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `10.63% <0%> (-0.48%)` | :arrow_down: |
| [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `7.14% <0%> (-0.22%)` | :arrow_down: |
| [...et/assets/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkU3RhdGUuanM=) | `65.45% <0%> (-8.02%)` | :arrow_down: |
| [...ets/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvdHJhbnNmb3JtUHJvcHMuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `5.93% <0%> (-0.68%)` | :arrow_down: |
| [...ssets/src/dashboard/components/FilterIndicator.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9GaWx0ZXJJbmRpY2F0b3IuanN4) | `100% <100%> (ø)` | :arrow_up: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9GaWx0ZXJJbmRpY2F0b3JHcm91cC5qc3g=) | `100% <100%> (ø)` | :arrow_up: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/8166/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=footer). Last update [be33934...956cb9f](https://codecov.io/gh/apache/incubator-superset/pull/8166?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org