[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1515: Add storage rowwise iterator
URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616092
 
 

 ##########
 File path: be/src/olap/iterators.h
 ##########
 @@ -0,0 +1,53 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "common/status.h"
+
+namespace doris {
+
+class RowBlockV2;
+class SchemaV2;
+
+struct StorageReadOptions {
+};
+
+// Used to read data in RowBlockV2 one by one
+class RowwiseIterator {
+public:
+    RowwiseIterator() { }
+    virtual ~RowwiseIterator() { }
+
+    // Initialize this iterator and make it ready to ready with
+    // input options.
+    // Input options may contain scan range in which this scan.
+    // Return Status::OK() if init successfully,
+    // Return other error otherwise
+    virtual Status init(const StorageReadOptions& opts) = 0;
+
+    // If there is any valid data, this function will load data
+    // into input batch with Status::OK() returned
+    // If there is no data to read, will return Status::EndOfFile.
+    // If oter error happened, other error code will be returned.
 
 Review comment:
   ```suggestion
       // If other error happens, other error code will be returned.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org