You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Chris Goffinet (JIRA)" <ji...@apache.org> on 2009/10/27 19:40:59 UTC
[jira] Created: (THRIFT-612) readFrame being called out of scope
readFrame being called out of scope
-----------------------------------
Key: THRIFT-612
URL: https://issues.apache.org/jira/browse/THRIFT-612
Project: Thrift
Issue Type: Bug
Components: Library (Python)
Affects Versions: 0.1, 0.2
Reporter: Chris Goffinet
Fix For: 0.1, 0.2
Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
ERROR:root:global name 'readFrame' is not defined
Traceback (most recent call last):
fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
readFrame()
NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-612) readFrame being called out of scope
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-612.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.1)
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771058#action_12771058 ]
Esteve Fernandez commented on THRIFT-612:
-----------------------------------------
> How did this happen? It's an obvious bug/fix, but this path shouldn't actually be triggered
> under normal operation.
That's why I was asking for a test before committing the patch.
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771064#action_12771064 ]
David Reiss commented on THRIFT-612:
------------------------------------
Sorry for stepping on your toes. :(
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770677#action_12770677 ]
Esteve Fernandez commented on THRIFT-612:
-----------------------------------------
+1 Looks good to me. Do you have test so that we make sure there are no regressions in the future?
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.1, 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771073#action_12771073 ]
Chris Goffinet commented on THRIFT-612:
---------------------------------------
I'll look into it with one of our engineers who ran into the issue. I think it might be related to the fact that we had to use THRIFT-347 recently.
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771070#action_12771070 ]
Esteve Fernandez commented on THRIFT-612:
-----------------------------------------
I wasn't actually complaining at all, sorry if I sounded like that :-)
I'm just curious how could that bug be introduced and we never noticed. You're completely right that that path shouldn't execute in normal circumstances, so it's even weirder.
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770997#action_12770997 ]
David Reiss commented on THRIFT-612:
------------------------------------
How did this happen? It's an obvious bug/fix, but this path shouldn't actually be triggered under normal operation.
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.1, 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-612) readFrame being called out of scope
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771074#action_12771074 ]
David Reiss commented on THRIFT-612:
------------------------------------
NP. I know how the bug was introduced: I'm used to writing C++ code, and not needing a "self." for each method call. I only tested this code in the context of a normal method call.
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-612) readFrame being called out of scope
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned THRIFT-612:
-------------------------------------
Assignee: Jonathan Ellis
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Assignee: Jonathan Ellis
> Fix For: 0.1, 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-612) readFrame being called out of scope
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated THRIFT-612:
----------------------------------
Attachment: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.1, 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-612) readFrame being called out of scope
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned THRIFT-612:
-------------------------------------
Assignee: (was: Jonathan Ellis)
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Fix For: 0.1, 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-612) readFrame being called out of scope
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-612.
--------------------------------
Assignee: Chris Goffinet
> readFrame being called out of scope
> -----------------------------------
>
> Key: THRIFT-612
> URL: https://issues.apache.org/jira/browse/THRIFT-612
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Affects Versions: 0.1, 0.2
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Fix For: 0.2
>
> Attachments: 0001-Added-self-so-that-readFrame-does-not-throw-an-error.patch
>
>
> ERROR:root:global name 'readFrame' is not defined
> Traceback (most recent call last):
> fastbinary.decode_binary(self, iprot.trans, (self.__class__, self.thrift_spec))
> File "build/bdist.macosx-10.6-i386/egg/thrift/transport/TTransport.py", line 301, in cstringio_refill
> readFrame()
> NameError: global name 'readFrame' is not defined
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.