You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2017/03/01 09:28:40 UTC
[GitHub] cloudstack pull request #1980: CLOUDSTACK-9805: Display VR list in network d...
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1980
CLOUDSTACK-9805: Display VR list in network details
Displays a VR tab that lists VRs for the network in the detail views. This has come up several times, and useful for admins when they want to reboot/destroy or view VR associated with a network.
Pinging for review - @abhinandanprateek @borisstoyanov @DaanHoogland @PaulAngus @karuturi @koushik-das
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack vr-ui-tab
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1980.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1980
----
commit 20d16c8c272faaf78a17d64f2e4a129f45504775
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2017-03-01T09:22:13Z
CLOUDSTACK-9805: Display VR list in network details
Displays a VR tab that lists VRs for the network in the detail views
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Is it only showing VR or other appliances providing service in that network? If it is the latter then the tab name is appropriate otherwise it is better to name it something like "Virtual Routers" to avoid confusion.
Verify that it is working as expected for RVR, VPC, basic zone network and other possible scenarios.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd it seems we can discard 'router' in vpc part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Who (user type) has visibility tab of this tab?
can it be hidden ? many service providers **_may_** not want users to see this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd Looks great! Shall we do the same for the VPC routers, so that the overviews look the same?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@PaulAngus @ustcweizhou fixed now, the tab is displayed only to admins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
is there any issue for normal users ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@ustcweizhou @PaulAngus sure, I can add a tab filter to allow only admins to see this. Right now, whoever can see the network tab(s) can see this tab too. I'll fix this asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@karuturi this is a simple UI change with screenshots attached, and has enough LGTM. Please merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/1980
LGTM (based on code only)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/1980
Nice @rhtyd LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@DaanHoogland @abhinandanprateek @borisstoyanov @koushik-das @remibergsma @karuturi let's lgtm and merge this? thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@karuturi this is ready for merge, has the screenshots and lgtms
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@remibergsma thanks, I've found time to fix this now:
@koushik-das yes all cases checked and covered for vpc, shared networks and isolated networks. Label fixed to 'Virtual Routers' now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---