[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20043#discussion_r159227015
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -56,7 +56,36 @@ import org.apache.spark.util.{ParentClassLoader, Utils}
      * @param value A term for a (possibly primitive) value of the result of the evaluation. Not
      *              valid if `isNull` is set to `true`.
      */
    -case class ExprCode(var code: String, var isNull: String, var value: String)
    +case class ExprCode(var code: String, var isNull: ExprValue, var value: ExprValue)
    +
    +
    +// An abstraction that represents the evaluation result of [[ExprCode]].
    +abstract class ExprValue
    --- End diff --
    
    OK let's keep it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org