You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/23 13:09:36 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

asdf2014 opened a new pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   Fixes #1319
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320#issuecomment-1050922143


   
   
   
   
   > > I think what you need to work out is why CI doesn't check ut, maybe you should look at the checkStyle file.
   > 
   > @CalvinKirs The root cause is not about the checkStyle file but the pom file. After removed the skip configuration from pom file, the check style is working again. May I ask do you know the historical reason of adding the skip config here šŸ˜… cc @wuchunfu
   
   This module is a modification of `typesafe`, so I want to keep the format as consistent (and `typesafe`) as possible, well, that might not be a big problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320#issuecomment-1048835636


   Hi @CalvinKirs, thanks for your comment. Indeed, Iā€™m working on it, but this PR still can be merged, right. Also we should keep the relate issue open until the root cause has been located and solved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320#issuecomment-1049413579


   > Hi @CalvinKirs, thanks for your comment. Indeed, Iā€™m working on it, but this PR still can be merged, right. Also we should keep the relate issue open until the root cause has been located and solved.
   
   @asdf2014 I think it is still necessary to find out why ci is not checked, and then check and modify it as a whole. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320#issuecomment-1050813999


   > I think what you need to work out is why CI doesn't check ut, maybe you should look at the checkStyle file.
   
   @CalvinKirs The root cause is not about the checkStyle file but the pom file. After removed the skip configuration from pom file, the check style is working again. May I ask do you know the historical reason of adding the skip config here šŸ˜…  cc @wuchunfu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1320: [Improve#1319] [code style] config module enables checkstyle

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1320: [Bug] [code style] Fix some code that does not meet the requirements of Code Style

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1320:
URL: https://github.com/apache/incubator-seatunnel/pull/1320#issuecomment-1049414926


   @wuchunfu Sure, if you say so


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org