[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2998: ARTEMIS-2641 Openwire client runs out of credits after reconnection

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2998: ARTEMIS-2641 Openwire client runs out of credits after reconnection
URL: https://github.com/apache/activemq-artemis/pull/2998#discussion_r387525491
 
 

 ##########
 File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
 ##########
 @@ -380,6 +383,11 @@ public void setPrefetchSize(int prefetchSize) {
       this.prefetchSize = prefetchSize;
       this.currentWindow.set(prefetchSize);
       this.info.setPrefetchSize(prefetchSize);
+      if (this.prefetchSize == 0) {
+         messagePullHandler.compareAndSet(null, new MessagePullHandler());
 
 Review comment:
   what do you mean if it wont succeed? if its not null it means it already had a pullhandler set, no need to assign a new one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services