[GitHub] [buildstream] gtristan commented on issue #1460: Shouldn't use a cached failed build with a different strict key

[GitBox <gi...@apache.org>]

gtristan commented on issue #1460:
URL: https://github.com/apache/buildstream/issues/1460#issuecomment-1042587685


   > Building in non-strict mode, I got one usual linker error: a library bumped the version, and a library that depends on it wasn't rebuilt and I was building a third element that depends on both. 
   
   So we're on the same page here: The above type of error is expected in `non-strict` build correct ? Because the dependency of a library was not explicitly declared as a [strict dependency](https://docs.buildstream.build/master/format_declaring.html#expressing-dependencies), and in this particular case it perhaps should have been, given that the versioning information of the library is relevant in this case and causes errors down the line at build time ?
   
   > ... I bst artifact delete both libraries, disable the remote cache, and launch the build again. After building some stuff, I am presented with the exact same error.
   >
   > I had a big WTF moment, before remembering that bst has cached failures. Retrying the build indeed works.
   >
   > I think we shouldn't present a different build (i.e. a build with a different strict key) as the same.
   
   But I'm a bit lost at this point as to what is going on and what happened.
   
   Perhaps the problem is that `bst artifact delete` will only delete a single artifact, for which it has resolved the key for in the session of running `bst artifact delete` (was `--no-strict` also specified at `bst artifact delete time` ?), and does not provide any option to delete *all* locally cached artifacts for a given element ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org