You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2012/11/30 03:15:59 UTC

[jira] [Created] (HADOOP-9108) Add a method to clear terminateCalled to ExitUtil for test cases

Kihwal Lee created HADOOP-9108:
----------------------------------

             Summary: Add a method to clear terminateCalled to ExitUtil for test cases
                 Key: HADOOP-9108
                 URL: https://issues.apache.org/jira/browse/HADOOP-9108
             Project: Hadoop Common
          Issue Type: Improvement
          Components: util
    Affects Versions: 0.23.5, 2.0.2-alpha
            Reporter: Kihwal Lee


Currently once terminateCalled is set, it will stay set since it's a class static variable. This can break test cases where multiple test cases run in one jvm. In MiniDfsCluster, it should be cleared during shutdown for the next test case to run properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HADOOP-9108) Add a method to clear terminateCalled to ExitUtil for test cases

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kihwal Lee resolved HADOOP-9108.
--------------------------------

    Resolution: Invalid
    
> Add a method to clear terminateCalled to ExitUtil for test cases
> ----------------------------------------------------------------
>
>                 Key: HADOOP-9108
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9108
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.0.2-alpha, 0.23.5
>            Reporter: Kihwal Lee
>
> Currently once terminateCalled is set, it will stay set since it's a class static variable. This can break test cases where multiple test cases run in one jvm. In MiniDfsCluster, it should be cleared during shutdown for the next test case to run properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HADOOP-9108) Add a method to clear terminateCalled to ExitUtil for test cases

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kihwal Lee reopened HADOOP-9108:
--------------------------------

      Assignee: Kihwal Lee

I found out the necessary changes have already been made in trunk and branch-2 by HDFS-3663 and HDFS-3765.  But we cannot simply pull these patches to branch-0.23 because HDFS-3765 contains more than just ExitUtil change.

I will use this jira to implement something equivalent for branch-0.23. Since this is for tests, a slight divergence should be of no concern.
                
> Add a method to clear terminateCalled to ExitUtil for test cases
> ----------------------------------------------------------------
>
>                 Key: HADOOP-9108
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9108
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.0.2-alpha, 0.23.5
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>
> Currently once terminateCalled is set, it will stay set since it's a class static variable. This can break test cases where multiple test cases run in one jvm. In MiniDfsCluster, it should be cleared during shutdown for the next test case to run properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira