You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/26 21:46:16 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #1984:
[NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
BradWalker opened a new pull request #1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
URL: https://github.com/apache/netbeans/pull/1984
This removes all the ThreadLocal rawtype warnings..
[repeat] /home/bwalker/src/netbeans/platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java:44: warning: [rawtypes] found ra
w type: ThreadLocal
[repeat] private static ThreadLocal reentrantCheck = new ThreadLocal();
[repeat] ^
[repeat] missing type arguments for generic class ThreadLocal<T>
[repeat] where T is a type-variable:
[repeat] T extends Object declared in class ThreadLocal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #1984:
[NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
URL: https://github.com/apache/netbeans/pull/1984#discussion_r385871599
##########
File path: ide/versioning.util/src/org/netbeans/modules/turbo/Memory.java
##########
@@ -53,7 +53,7 @@
public static final Object NULL = new Object();
/** Keep reference to last isPrepared result. */
- public static final ThreadLocal prepared = new ThreadLocal();
+ public static final ThreadLocal<Entry> prepared = new ThreadLocal<>();
Review comment:
Good catch!! It's fixed now..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1984:
[NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
URL: https://github.com/apache/netbeans/pull/1984#issuecomment-592921684
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #1984:
[NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
URL: https://github.com/apache/netbeans/pull/1984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request
#1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #1984: [NETBEANS-3923] - cleanup ThreadLocal rawtype warnings
URL: https://github.com/apache/netbeans/pull/1984#discussion_r385278046
##########
File path: ide/versioning.util/src/org/netbeans/modules/turbo/Memory.java
##########
@@ -53,7 +53,7 @@
public static final Object NULL = new Object();
/** Keep reference to last isPrepared result. */
- public static final ThreadLocal prepared = new ThreadLocal();
+ public static final ThreadLocal<Entry> prepared = new ThreadLocal<>();
Review comment:
The users of `prepared` in this class could now drop their cast (I think else you are introducing another warning).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists