[GitHub] [rocketmq] xiangwangcheng commented on a change in pull request #1313: add missing log

[GitBox <gi...@apache.org>]

xiangwangcheng commented on a change in pull request #1313: add missing log
URL: https://github.com/apache/rocketmq/pull/1313#discussion_r305693783
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java
 ##########
 @@ -71,10 +71,9 @@ public static BrokerController start(BrokerController controller) {
             }
 
             log.info(tip);
-            System.out.printf("%s%n", tip);
             return controller;
         } catch (Throwable e) {
-            e.printStackTrace();
+            log.error("BrokerStartup fail to boot.", e);
 
 Review comment:
   @77yang  When the application booted successfully, generally, we redirect the log to log file. And when it comes to the process of starting the application, I agree with what @ShannonDing said. It is friendly to users if they can know when and how the application failed to start QUICKLY(Of course, log them into file is also necessary). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services