You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/08/25 05:35:50 UTC

[mp2] cgi tests

Hi,
   I'm just wondering if anyone has seen any problems with
the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
=================================================================
modules/cgi....1..5
# Running under perl version 5.008 for MSWin32
# Win32::BuildNumber 806
# Using Test.pm version 1.24
# testing : GET /TestModules__cgi?PARAM=2
# expected: ok 2
# received:
not ok 1
# testing : POST /TestModules__cgi
# PARAM=%33
# expected: ok 3
# received:
not ok 2
# testing : file upload
# expected: ok 4
# received:
not ok 3
# expected: (?-xism:^text/test-output)
# received: Content-type header
not ok 4
# testing : X-Perl-Module header
# expected: TestModules::cgi
# received: TestModules::cgi
ok 5
FAILED tests 1-4

modules/cgiupload....1..2
# Running under perl version 5.008 for MSWin32
# Win32::BuildNumber 806
# Using Test.pm version 1.24
# body_len=0, file_len=256148
not ok 1
# body_len=0, file_len=256148
not ok 2
FAILED tests 1-2
=============================================================
This is with CGI.pm-3.00.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 27 Aug 2003, Stas Bekman wrote:

> Randy Kobes wrote:
[ .. ]
> >     This has been fixed, and the associated perlio.t test
> > runs on Win32, and passes all but one subtest (I don't have
> > the details handy, but the failure is due to a difference
> > of a single leading space between expected and actual
> > output).
>
> Ah, thanks, now I remember, you mentioned it earlier. I
> guess you didn't have time to debug. Again this is not
> urgent. But we should probably log it somewhere in the
> STATUS file. At the moment cvs doesn't seem to be working
> for me, may be it works for you.

I haven't tried it either, but when I do, and assuming
it works, I'll log it in the STATUS.

> but at least we can s/ eval {require APR::PerlIO }/require
> APR::PerlIO/, right?

That should be OK, at least on Win32 ....

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:

>>>>>>>It's possible that the problem comes from the new PerlIO
>>>>>>>Layer, try testing again after disabling it:
>>>>>>
>>>>>>[ .. ]
>>>>>>  You're right - disabling PERLIO_LAYERS allows the
>>>>>>modules/cgi.t and modules/cgiupload.t to pass ...
>>>>>>I'll try to track down what changes in the past few
>>>>>>weeks led to this. Thanks.
>>
>>Hmm, is this still true? from t/response/TestAPR/perlio.pm:
>>
>>     # 1) APR::PerlIO is not available on all platforms
>>     # 2) on those platforms where available,
>>     #    PerlIO-enabled perl is needed to run this test
>>     my $run = eval { require APR::PerlIO } &&
>>         APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED()
>>             ? 1
>>             : have  { "This Perl build doesn't support PerlIO layers" => 0 };
>>
>>And if so, that explains the problem with moving to IO layers as the IO
>>"transport" on win32.
>>
>>Hasn't this been fixed? I remember the problem was with the missing symbol
>>which is fixed for sure. can we remove eval {} there?
> 
> 
> Hi Stas,
>     This has been fixed, and the associated perlio.t test
> runs on Win32, and passes all but one subtest (I don't have
> the details handy, but the failure is due to a difference
> of a single leading space between expected and actual
> output).

Ah, thanks, now I remember, you mentioned it earlier. I guess you didn't have 
time to debug. Again this is not urgent. But we should probably log it 
somewhere in the STATUS file. At the moment cvs doesn't seem to be working for 
me, may be it works for you.

but at least we can s/ eval {require APR::PerlIO }/require APR::PerlIO/, right?

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 27 Aug 2003, Stas Bekman wrote:

> Stas Bekman wrote:
> > Randy Kobes wrote:
> >> On Wed, 27 Aug 2003, Stas Bekman wrote:
> >>> Randy Kobes wrote:
> >>>> On Mon, 25 Aug 2003, Stas Bekman wrote:
> >>>>> It's possible that the problem comes from the new PerlIO
> >>>>> Layer, try testing again after disabling it:
> >>>> [ .. ]
> >>>>   You're right - disabling PERLIO_LAYERS allows the
> >>>> modules/cgi.t and modules/cgiupload.t to pass ...
> >>>> I'll try to track down what changes in the past few
> >>>> weeks led to this. Thanks.
>
> Hmm, is this still true? from t/response/TestAPR/perlio.pm:
>
>      # 1) APR::PerlIO is not available on all platforms
>      # 2) on those platforms where available,
>      #    PerlIO-enabled perl is needed to run this test
>      my $run = eval { require APR::PerlIO } &&
>          APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED()
>              ? 1
>              : have  { "This Perl build doesn't support PerlIO layers" => 0 };
>
> And if so, that explains the problem with moving to IO layers as the IO
> "transport" on win32.
>
> Hasn't this been fixed? I remember the problem was with the missing symbol
> which is fixed for sure. can we remove eval {} there?

Hi Stas,
    This has been fixed, and the associated perlio.t test
runs on Win32, and passes all but one subtest (I don't have
the details handy, but the failure is due to a difference
of a single leading space between expected and actual
output).

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Stas Bekman wrote:
> Randy Kobes wrote:
> 
>> On Wed, 27 Aug 2003, Stas Bekman wrote:
>>
>>
>>> Randy Kobes wrote:
>>>
>>>> On Mon, 25 Aug 2003, Stas Bekman wrote:
>>>>
>>>>
>>>>> It's possible that the problem comes from the new PerlIO
>>>>> Layer, try testing again after disabling it:
>>>>
>>>>
>>>> [ .. ]
>>>> Hi Stas,
>>>>   You're right - disabling PERLIO_LAYERS allows the
>>>> modules/cgi.t and modules/cgiupload.t to pass ...
>>>> I'll try to track down what changes in the past few
>>>> weeks led to this. Thanks.

Hmm, is this still true? from t/response/TestAPR/perlio.pm:

     # 1) APR::PerlIO is not available on all platforms
     # 2) on those platforms where available,
     #    PerlIO-enabled perl is needed to run this test
     my $run = eval { require APR::PerlIO } &&
         APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED()
             ? 1
             : have  { "This Perl build doesn't support PerlIO layers" => 0 };

And if so, that explains the problem with moving to IO layers as the IO 
"transport" on win32.

Hasn't this been fixed? I remember the problem was with the missing symbol 
which is fixed for sure. can we remove eval {} there?

I want to make 'APR::PerlIO' always succeed no matter what OS we are on, since 
eval {} hides other problems, e.g. run-time symbol resolution.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Wed, 27 Aug 2003, Stas Bekman wrote:
> 
> 
>>Randy Kobes wrote:
>>
>>>On Mon, 25 Aug 2003, Stas Bekman wrote:
>>>
>>>
>>>>It's possible that the problem comes from the new PerlIO
>>>>Layer, try testing again after disabling it:
>>>
>>>[ .. ]
>>>Hi Stas,
>>>   You're right - disabling PERLIO_LAYERS allows the
>>>modules/cgi.t and modules/cgiupload.t to pass ...
>>>I'll try to track down what changes in the past few
>>>weeks led to this. Thanks.
>>
>>That's crucial then, as we may urgently need to fix
>>something in perl, before 5.8.1 was released. You didn't
>>tell which version you have the problem with.  Does it
>>work with 5.8.0? If you use 5.8.1, are you using the very
>>latest checkout? rsync -acvz --delete --force
>>rsync://ftp.linux.activestate.com/perl-5.8.x ./perl-5.8.1
> 
> 
> Hi Stas,
>    Sorry for the delay - we're having some network problems
> here (unrelated to any virus ...). I did the above with
> a perl-5.8.0 (based on the ActivePerl sources for the
> latest 8xx build.

OK, so it's then less urgent (i was afraid that something might have been 
introduced in 5.8.1).

Running those tests with:

env MOD_PERL_TRACE=o t/TEST -v modules/cgi.t

should help you debug what's going on inside.

You can compare the output with mine to tell what's wrong.

[Wed Aug 27 10:40:25 2003] [debug] prefork.c(1039): AcceptMutex: sysvsem 
(default: sysvsem)
modperl_io_perlio_override_stdin: start
PerlIOApache_pushed: done
PerlIOApache_open: mode r
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdin: end

modperl_io_perlio_override_stdout: start
PerlIOApache_pushed: done
PerlIOApache_open: mode w
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdout: end

[Wed Aug 27 10:40:27 2003] [error] server reached MaxClients setting, consider 
raising the MaxClients setting
PerlIOApache_write: 4 bytes [ok 2]
modperl_io_perlio_restore_stdin: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_popped: done
modperl_io_perlio_restore_stdin: end

modperl_io_perlio_restore_stdout: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_flush: 4 bytes [ok 2]
PerlIOApache_popped: done
modperl_io_perlio_restore_stdout: end

modperl_io_perlio_override_stdin: start
PerlIOApache_pushed: done
PerlIOApache_open: mode r
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdin: end

modperl_io_perlio_override_stdout: start
PerlIOApache_pushed: done
PerlIOApache_open: mode w
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdout: end

PerlIOApache_read: wanted 9b, read 9b [PARAM=%338)]
PerlIOApache_write: 4 bytes [ok 3]
modperl_io_perlio_restore_stdin: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_popped: done
modperl_io_perlio_restore_stdin: end

modperl_io_perlio_restore_stdout: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_flush: 4 bytes [ok 3]
PerlIOApache_popped: done
modperl_io_perlio_restore_stdout: end

modperl_io_perlio_override_stdin: start
PerlIOApache_pushed: done
PerlIOApache_open: mode r
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdin: end

modperl_io_perlio_override_stdout: start
PerlIOApache_pushed: done
PerlIOApache_open: mode w
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdout: end

PerlIOApache_read: wanted 130b, read 130b [--742617000027
Content-Disposition: form-data; name="HTTPUPLOAD"; filename="b"
Content-Type: text/plain

4
--742617000027--
ck]
PerlIOApache_write: 4 bytes [ok 4]
modperl_io_perlio_restore_stdin: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_popped: done
modperl_io_perlio_restore_stdin: end

modperl_io_perlio_restore_stdout: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_flush: 4 bytes [ok 4]
PerlIOApache_popped: done
modperl_io_perlio_restore_stdout: end

modperl_io_perlio_override_stdin: start
PerlIOApache_pushed: done
PerlIOApache_open: mode r
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdin: end

modperl_io_perlio_override_stdout: start
PerlIOApache_pushed: done
PerlIOApache_open: mode w
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdout: end

PerlIOApache_write: 24 bytes [no param or upload data
]
modperl_io_perlio_restore_stdin: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_popped: done
modperl_io_perlio_restore_stdin: end

modperl_io_perlio_restore_stdout: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_flush: 24 bytes [no param or upload data
]
PerlIOApache_popped: done
modperl_io_perlio_restore_stdout: end

modperl_io_perlio_override_stdin: start
PerlIOApache_pushed: done
PerlIOApache_open: mode r
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdin: end

modperl_io_perlio_override_stdout: start
PerlIOApache_pushed: done
PerlIOApache_open: mode w
PerlIOApache_fileno: did nothing
modperl_io_perlio_override_stdout: end

PerlIOApache_write: 24 bytes [no param or upload data
]
modperl_io_perlio_restore_stdin: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_popped: done
modperl_io_perlio_restore_stdin: end

modperl_io_perlio_restore_stdout: start
PerlIOApache_fileno: did nothing
PerlIOApache_close: done
PerlIOApache_flush: 24 bytes [no param or upload data
]
PerlIOApache_popped: done
modperl_io_perlio_restore_stdout: end

[Wed Aug 27 10:40:27 2003] [info] Child process pid=31206 is exiting
[Wed Aug 27 10:40:27 2003] [info] Child process pid=31209 is exiting


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Wed, 27 Aug 2003, Stas Bekman wrote:

> Randy Kobes wrote:
> > On Mon, 25 Aug 2003, Stas Bekman wrote:
> >
> >>It's possible that the problem comes from the new PerlIO
> >>Layer, try testing again after disabling it:
> > [ .. ]
> > Hi Stas,
> >    You're right - disabling PERLIO_LAYERS allows the
> > modules/cgi.t and modules/cgiupload.t to pass ...
> > I'll try to track down what changes in the past few
> > weeks led to this. Thanks.
>
> That's crucial then, as we may urgently need to fix
> something in perl, before 5.8.1 was released. You didn't
> tell which version you have the problem with.  Does it
> work with 5.8.0? If you use 5.8.1, are you using the very
> latest checkout? rsync -acvz --delete --force
> rsync://ftp.linux.activestate.com/perl-5.8.x ./perl-5.8.1

Hi Stas,
   Sorry for the delay - we're having some network problems
here (unrelated to any virus ...). I did the above with
a perl-5.8.0 (based on the ActivePerl sources for the
latest 8xx build.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Mon, 25 Aug 2003, Stas Bekman wrote:
> 
> 
>>It's possible that the problem comes from the new PerlIO Layer, try testing
>>again after disabling it:
> 
> [ .. ]
> Hi Stas,
>    You're right - disabling PERLIO_LAYERS allows the
> modules/cgi.t and modules/cgiupload.t to pass ...
> I'll try to track down what changes in the past few
> weeks led to this. Thanks.

That's crucial then, as we may urgently need to fix something in perl, before 
5.8.1 was released. You didn't tell which version you have the problem with. 
Does it work with 5.8.0? If you use 5.8.1, are you using the very latest 
checkout?
rsync -acvz --delete --force rsync://ftp.linux.activestate.com/perl-5.8.x 
./perl-5.8.1


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 25 Aug 2003, Stas Bekman wrote:

> It's possible that the problem comes from the new PerlIO Layer, try testing
> again after disabling it:
[ .. ]
Hi Stas,
   You're right - disabling PERLIO_LAYERS allows the
modules/cgi.t and modules/cgiupload.t to pass ...
I'll try to track down what changes in the past few
weeks led to this. Thanks.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Tue, 2 Sep 2003, Stas Bekman wrote:

> Randy Kobes wrote:
[ .. ]
> > The following seems to fix the problems both with
> > t/modules/cgi.t and t/modules/cgiupload.t:
> > ============================================================
> > Index: src/modules/perl/modperl_io_apache.c
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io_apache.c,v
> > retrieving revision 1.3
> > diff -u -r1.3 modperl_io_apache.c
> > --- src/modules/perl/modperl_io_apache.c	21 Aug 2003 01:37:20 -0000	1.3
> > +++ src/modules/perl/modperl_io_apache.c	2 Sep 2003 01:37:55 -0000
> > @@ -187,7 +187,7 @@
> >      sizeof(PerlIO_funcs),
> >      "Apache",
> >      sizeof(PerlIOApache),
> > -    PERLIO_K_MULTIARG,
> > +    PERLIO_K_MULTIARG | PERLIO_K_RAW,
> >      PerlIOApache_pushed,
> >      PerlIOApache_popped,
> >      PerlIOApache_open,
> > ===============================================================
> > I haven't tested this on Unix, though.
>
> Excellent catch, it works on linux (since unix has no need for binmode).
[ .. ]
> Please commit.
>
> Also we probably need to add it to
> xs/APR/PerlIO/apr_perlio.c (again | with
> PERLIO_K_MULTIARG), can you think of a test to add to
> t/response/TestAPR/perlio.t that will break it in a
> similar way, before we fix it?

OK, thanks - I've done that. I'll work on a test that
illustrates the problem for APR::PerlIO, and submit
that soon.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Mon, 25 Aug 2003, Stas Bekman wrote:
> 
> 
>>Randy Kobes wrote:
>>
>>>On Sun, 24 Aug 2003, Stas Bekman wrote:
>>>
>>>
>>>>Randy Kobes wrote:
>>>>
>>>>>  I'm just wondering if anyone has seen any problems with
>>>>>the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
>>>>>the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
> 
> [ ... ]
> 
>>It's possible that the problem comes from the new PerlIO
>>Layer, try testing again after disabling it:
> 
> 
> The following seems to fix the problems both with
> t/modules/cgi.t and t/modules/cgiupload.t:
> ============================================================
> Index: src/modules/perl/modperl_io_apache.c
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io_apache.c,v
> retrieving revision 1.3
> diff -u -r1.3 modperl_io_apache.c
> --- src/modules/perl/modperl_io_apache.c	21 Aug 2003 01:37:20 -0000	1.3
> +++ src/modules/perl/modperl_io_apache.c	2 Sep 2003 01:37:55 -0000
> @@ -187,7 +187,7 @@
>      sizeof(PerlIO_funcs),
>      "Apache",
>      sizeof(PerlIOApache),
> -    PERLIO_K_MULTIARG,
> +    PERLIO_K_MULTIARG | PERLIO_K_RAW,
>      PerlIOApache_pushed,
>      PerlIOApache_popped,
>      PerlIOApache_open,
> ===============================================================
> I haven't tested this on Unix, though.

Excellent catch, it works on linux (since unix has no need for binmode). From 
the perliol manpage:

            * PERLIO_K_RAW
                The layer is acceptable to have in a binmode(FH) stack - i.e.
                it does not (or will configure itself not to) transform bytes
                passing through it.
CGI.pm has:

if ($needs_binmode) {
     $CGI::DefaultClass->binmode(main::STDOUT);
     $CGI::DefaultClass->binmode(main::STDIN);
     $CGI::DefaultClass->binmode(main::STDERR);
}

Please commit.

Also we probably need to add it to xs/APR/PerlIO/apr_perlio.c (again | with 
PERLIO_K_MULTIARG), can you think of a test to add to 
t/response/TestAPR/perlio.t that will break it in a similar way, before we fix it?


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Mon, 25 Aug 2003, Stas Bekman wrote:

> Randy Kobes wrote:
> > On Sun, 24 Aug 2003, Stas Bekman wrote:
> >
> >>Randy Kobes wrote:
> >>>   I'm just wondering if anyone has seen any problems with
> >>>the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
> >>>the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
[ ... ]
> It's possible that the problem comes from the new PerlIO
> Layer, try testing again after disabling it:

The following seems to fix the problems both with
t/modules/cgi.t and t/modules/cgiupload.t:
============================================================
Index: src/modules/perl/modperl_io_apache.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io_apache.c,v
retrieving revision 1.3
diff -u -r1.3 modperl_io_apache.c
--- src/modules/perl/modperl_io_apache.c	21 Aug 2003 01:37:20 -0000	1.3
+++ src/modules/perl/modperl_io_apache.c	2 Sep 2003 01:37:55 -0000
@@ -187,7 +187,7 @@
     sizeof(PerlIO_funcs),
     "Apache",
     sizeof(PerlIOApache),
-    PERLIO_K_MULTIARG,
+    PERLIO_K_MULTIARG | PERLIO_K_RAW,
     PerlIOApache_pushed,
     PerlIOApache_popped,
     PerlIOApache_open,
===============================================================
I haven't tested this on Unix, though.
-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> On Sun, 24 Aug 2003, Stas Bekman wrote:
> 
> 
>>Randy Kobes wrote:
>>
>>>Hi,
>>>   I'm just wondering if anyone has seen any problems with
>>>the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
>>>the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
>>>=================================================================
>>
>>[...]
>>
>>
>>>FAILED tests 1-2
>>>=============================================================
>>>This is with CGI.pm-3.00.
>>
>>I can't tell without seeing the error_log file's relevant parts.
>>
>>Did you have this problem with earlier versions of CGI.pm?
>>Try downgrading to 2.98? I know that Randal was mentioning
>>some problems with recent CGI.pm versions. I've upgraded
>>to 3.00 just now and everything still works on linux.
> 
> 
> That's reassuring it works on linux ... There wasn't
> anything in the error logs, and I've tried downgrading to
> earlier versions of CGI.pm, back to a point where there's
> compatibility problems with mod_perl 2, but with the same
> errors. I didn't have problems with this before, but that
> was 3 weeks ago, as I was away. I'll look more into this -
> thanks.

It's possible that the problem comes from the new PerlIO Layer, try testing 
again after disabling it:

Index: src/modules/perl/modperl_io_apache.h
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_io_apache.h,v
retrieving revision 1.1
diff -u -r1.1 modperl_io_apache.h
--- src/modules/perl/modperl_io_apache.h        20 Aug 2003 23:20:14 -0000 
   1.1
+++ src/modules/perl/modperl_io_apache.h        25 Aug 2003 18:02:39 -0000
@@ -1,7 +1,7 @@
  #ifndef MODPERL_IO_APACHE_H
  #define MODPERL_IO_APACHE_H

-#ifdef PERLIO_LAYERS
+#ifdef RANDY_TEST

  #include "perliol.h"
  /* XXX: should this be a Makefile.PL config option? */


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 24 Aug 2003, Stas Bekman wrote:

> Randy Kobes wrote:
> > Hi,
> >    I'm just wondering if anyone has seen any problems with
> > the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
> > the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
> > =================================================================
>
> [...]
>
> > FAILED tests 1-2
> > =============================================================
> > This is with CGI.pm-3.00.
>
> I can't tell without seeing the error_log file's relevant parts.
>
> Did you have this problem with earlier versions of CGI.pm?
> Try downgrading to 2.98? I know that Randal was mentioning
> some problems with recent CGI.pm versions. I've upgraded
> to 3.00 just now and everything still works on linux.

That's reassuring it works on linux ... There wasn't
anything in the error logs, and I've tried downgrading to
earlier versions of CGI.pm, back to a point where there's
compatibility problems with mod_perl 2, but with the same
errors. I didn't have problems with this before, but that
was 3 weeks ago, as I was away. I'll look more into this -
thanks.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp2] cgi tests

Posted by Stas Bekman <st...@stason.org>.
Randy Kobes wrote:
> Hi,
>    I'm just wondering if anyone has seen any problems with
> the t/modules/cgi.t and/or t/modules/cgiupload.t tests in
> the cvs mp2? On Win32 I'm getting failures (Apache/2.0.47):
> =================================================================

[...]

> FAILED tests 1-2
> =============================================================
> This is with CGI.pm-3.00.

I can't tell without seeing the error_log file's relevant parts.

Did you have this problem with earlier versions of CGI.pm? Try downgrading to 
2.98? I know that Randal was mentioning some problems with recent CGI.pm 
versions. I've upgraded to 3.00 just now and everything still works on linux.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org