You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/28 11:54:58 UTC
[GitHub] [camel-quarkus] ppalaga opened a new issue #819: Saga support
ppalaga opened a new issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604278796
> Another option would be to introduce a sort of `CamelContextCustomizerBuildItem` which can then be used by the core's [BuildProcessor](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L360) to do further customization of the camel context.
Isn't CamelMainListenerBuildItem doing just that? There is an example in MicroProfileMetricsProcessor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604251435
The camel-saga component provides a way to make a manual decision of complete or compensate a Saga transaction. For normal use of the Saga, you can refer to [SAGA EIP](https://camel.apache.org/components/latest/eips/saga-eip.html).
In term of the LRA (Long Running Action), it is more like a transaction model based on Saga pattern. You can refer to the [MicroProfile LRA](https://github.com/eclipse/microprofile-lra) to know more details about the APIs.
The camel-lra provides a LRASagaService to talk to the [Narayana LRA coordinator](https://github.com/jbosstm/narayana/tree/master/rts/lra) and I think we could leverage the narayana lra coordinator extension in quarkus if it get merged in the future.
Feel free to assign this issue to me and I will take a close look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604285944
> > Another option would be to introduce a sort of `CamelContextCustomizerBuildItem` which can then be used by the core's [BuildProcessor](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L360) to do further customization of the camel context.
>
> Isn't CamelMainListenerBuildItem doing just that? There is an example in MicroProfileMetricsProcessor.
yep when that's when main is enabled but those are generic services that do not depend on main
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604278796
> Another option would be to introduce a sort of `CamelContextCustomizerBuildItem` which can then be used by the core's [BuildProcessor](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L360) to do further customization of the camel context.
Isn't CamelMainListenerBuildItem doing just that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604371964
yeah, I totally agree that the doc would be very helpful !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604267785
There's no direct support so far.
One solution would be to use `CamelContextBuildItem` however to use it, we need to introduce a synchronization point i.e. by using [empty build items](https://quarkus.io/guides/writing-extensions#empty-build-items) as the Camel Context should be fully configured before [Camel Main](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L521) set up kicks in.
Another option would be to introduce a sort of `CamelContextCustomizerBuildItem` which can then be used by the core's [BuildProcessor](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L360) to do further customization of the camel context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604293342
> So these services can be added in the camel context before the main whenever it is enabled or not ?
I think so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604288105
So these services can be added in the camel context before the main whenever it is enabled or not ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604285299
Thanks @lburgazzoli and @ppalaga !
Is there any difference about the [contextConfigurerListener](https://github.com/apache/camel-quarkus/blob/master/extensions/microprofile-metrics/deployment/src/main/java/org/apache/camel/quarkus/component/microprofile/metrics/deployment/MicroProfileMetricsProcessor.java#L51) and [configureCamelContext](https://github.com/apache/camel-quarkus/blob/master/extensions/microprofile-metrics/deployment/src/main/java/org/apache/camel/quarkus/component/microprofile/metrics/deployment/MicroProfileMetricsProcessor.java#L60) in MicroProfileMetricsProcessor.java? It looks like both of them can do the configure with the camel context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604255406
@ppalaga is there any way to add a service in camel context at the build or runtime phase just like we do with the [LraServiceAutoConfiguration.java ](https://github.com/apache/camel-spring-boot/blob/master/components-starter/camel-lra-starter/src/main/java/org/apache/camel/service/lra/springboot/LraServiceAutoConfiguration.java#L74) in spring boot ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #819: Saga
support
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604285944
> > Another option would be to introduce a sort of `CamelContextCustomizerBuildItem` which can then be used by the core's [BuildProcessor](https://github.com/apache/camel-quarkus/blob/b8135432cb67a4739395671ea98f366d2e252b36/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java#L360) to do further customization of the camel context.
>
> Isn't CamelMainListenerBuildItem doing just that? There is an example in MicroProfileMetricsProcessor.
that's when main is enabled but those are generic services that do not require camel main
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604367391
> could be worth to raise a new issue to introduce the `CamelContextCustomizerBuildItem`
I am not against that, but please write a proper class level JavaDoc on the new BuildItem, explaining
* What happens before and after
* Sum up roughly which uses is it intended for and
* Explain the relationship to Core and Main.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-596477875
Not sure about the details, but we have a separate issue for LRA https://github.com/apache/camel-quarkus/issues/793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] zhfeng commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604364588
OK, I think it could be worth to raise a new issue to introduce the ```CamelContextCustomizerBuildItem``` for help to do such things, any thoughts ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] aldettinger commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
aldettinger commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-596410377
May relate to this [PR](https://github.com/quarkusio/quarkus/pull/6763).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604288982
> Thanks @lburgazzoli and @ppalaga !
>
> Is there any difference about the [contextConfigurerListener](https://github.com/apache/camel-quarkus/blob/master/extensions/microprofile-metrics/deployment/src/main/java/org/apache/camel/quarkus/component/microprofile/metrics/deployment/MicroProfileMetricsProcessor.java#L51) and [configureCamelContext](https://github.com/apache/camel-quarkus/blob/master/extensions/microprofile-metrics/deployment/src/main/java/org/apache/camel/quarkus/component/microprofile/metrics/deployment/MicroProfileMetricsProcessor.java#L60) in MicroProfileMetricsProcessor.java? It looks like both of them can do the configure with the camel context.
`configureCamelContext` seems to be a good candidate to be refactored to a `CamelContextCustomizerBuildItem`
`contextConfigurerListener` turn on message history as you can turn in off on camel-main with a property thus we need to force it if mp metrics is enabled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #819: Saga support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #819: Saga support
URL: https://github.com/apache/camel-quarkus/issues/819#issuecomment-604373226
> * Explain the relationship to Core and Main.
Like it has not relation to main :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services