You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by mice530 <gi...@git.apache.org> on 2016/01/05 19:47:26 UTC
[GitHub] thrift pull request: THRIFT-9999:In multiplexer mode, when data ge...
GitHub user mice530 opened a pull request:
https://github.com/apache/thrift/pull/773
THRIFT-9999:In multiplexer mode, when data gets big, error occurs in accepting data
THRIFT-9999:In multiplexer mode, when data gets big, delete hash of seqId may lead to wrong client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FroadUED/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/773.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #773
----
commit 9cf44edcb8e7b79f28aeef45c44cd896c83a3910
Author: amoschen(陈智浩) <am...@tencent.com>
Date: 2016-01-05T18:23:59Z
In multiplexer mode, when data gets big, delete hash of seqId may lead to wrong client.
commit c9e114d48457881b720b9da3479433c84fa54a0f
Author: amoschen(陈智浩) <am...@tencent.com>
Date: 2016-01-05T18:26:49Z
delete extra semicolon
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-9999:In multiplexer mode, when data ge...
Posted by mice530 <gi...@git.apache.org>.
Github user mice530 commented on the pull request:
https://github.com/apache/thrift/pull/773#issuecomment-170334291
My mistake. Paste the wrong ticket number.
I'll add some test cases when I get time next week. Too busy working this week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #773: THRIFT-9999:In multiplexer mode, when data gets big, erro...
Posted by mrlannigan <gi...@git.apache.org>.
Github user mrlannigan commented on the issue:
https://github.com/apache/thrift/pull/773
Looks like #1063 is fixing the same issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #773: THRIFT-9999:In multiplexer mode, when data gets bi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/773
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-9999:In multiplexer mode, when data ge...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/773#issuecomment-170418385
Could you rename your PR to include "THRIFT-3522" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-9999:In multiplexer mode, when data ge...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/773#issuecomment-169119235
Could you please follow our small set of [contribution guidelines](http://thrift.apache.org/docs/HowToContribute) and file a valid JIRA ticket for it, ideally including a test case that demonstrates the issue in more detail?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---