[GitHub] [thrift] Jens-G edited a comment on pull request #2042: THRIFT-5132 Warning in TSocket when using ssl connection

[GitBox <gi...@apache.org>]

Jens-G edited a comment on pull request #2042:
URL: https://github.com/apache/thrift/pull/2042#issuecomment-635932353


   118 commits to merge? Are you sure you did the right thing?
   
   > @Jens-G is it possible to recieve some reaction on pull-request?
   
   Sorry didn't see that, so late response. We regularly look through open PRs and one of the first criterions is whether CI is "red" or "green". If it is green (i.e. all checks pass) then someone will sooner or later look at it. 
   
   If there is no reaction on a "green" CI for say 10 days or so, you may politely ask and remind about the PR. 
   
   If the CI is "red", then your first action should be to try to fix the issues, rebase on master if necessary, and force push to the PR branch to trigger CI again. 
   
   Sometimes, unfortunately, you may get false negatives from CI due to various reasons, so if you are sure everything is correct, a simple rebase + force-push may be just enough in such a case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org