You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/05/02 07:15:01 UTC
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #2966: [GOBBLIN-1126] Make ORC compaction shuffle key configurable
codecov-io edited a comment on pull request #2966:
URL: https://github.com/apache/incubator-gobblin/pull/2966#issuecomment-619497656
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=h1) Report
> Merging [#2966](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/cc50c491cc40789300ad3019999cfa23f0027724&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `57.93%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2966 +/- ##
============================================
- Coverage 45.63% 45.62% -0.01%
- Complexity 9196 9240 +44
============================================
Files 1940 1943 +3
Lines 73574 73938 +364
Branches 8128 8179 +51
============================================
+ Hits 33574 33734 +160
- Misses 36873 37061 +188
- Partials 3127 3143 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/gobblin/compaction/mapreduce/orc/OrcUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNVdGlscy5qYXZh) | `56.22% <52.05%> (-16.70%)` | `49.00 <37.00> (+37.00)` | :arrow_down: |
| [...bblin/compaction/mapreduce/orc/OrcValueMapper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNWYWx1ZU1hcHBlci5qYXZh) | `75.00% <64.00%> (-6.43%)` | `8.00 <5.00> (-8.00)` | |
| [...action/mapreduce/CompactionOrcJobConfigurator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL0NvbXBhY3Rpb25PcmNKb2JDb25maWd1cmF0b3IuamF2YQ==) | `92.30% <100.00%> (+0.64%)` | `6.00 <0.00> (+1.00)` | |
| [...ompaction/mapreduce/RecordKeyDedupReducerBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleURlZHVwUmVkdWNlckJhc2UuamF2YQ==) | `90.32% <100.00%> (+0.66%)` | `11.00 <2.00> (+2.00)` | |
| [...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlEZWR1cFJlZHVjZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `10.00 <5.00> (+5.00)` | |
| [...n/java/org/apache/gobblin/util/logs/LogCopier.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbG9ncy9Mb2dDb3BpZXIuamF2YQ==) | `61.53% <0.00%> (-8.03%)` | `18.00% <0.00%> (ø%)` | |
| [...a/org/apache/gobblin/service/RequesterService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9SZXF1ZXN0ZXJTZXJ2aWNlLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `4.00% <0.00%> (ø%)` | |
| [...che/gobblin/yarn/YarnContainerSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkNvbnRhaW5lclNlY3VyaXR5TWFuYWdlci5qYXZh) | `58.62% <0.00%> (-5.02%)` | `6.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../org/apache/gobblin/yarn/GobblinYarnLogSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Mb2dTb3VyY2UuamF2YQ==) | `19.35% <0.00%> (-3.73%)` | `3.00% <0.00%> (ø%)` | |
| [.../apache/gobblin/yarn/GobblinApplicationMaster.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbkFwcGxpY2F0aW9uTWFzdGVyLmphdmE=) | `17.56% <0.00%> (-0.25%)` | `3.00% <0.00%> (ø%)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2966/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=footer). Last update [cc50c49...a4469bc](https://codecov.io/gh/apache/incubator-gobblin/pull/2966?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org