You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/13 11:02:16 UTC

[GitHub] [flink] SteNicholas opened a new pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

SteNicholas opened a new pull request #14631:
URL: https://github.com/apache/flink/pull/14631


   ## What is the purpose of the change
   
   *Currently deserialization of `CanalJsonDeserializationSchema` with the option 'canal-json.table.include' to filter out the binlog of the specified table could cause the exception because of the different table schema. Deserialization of `CanalJsonDeserializationSchema` should firstly deserialize to `JsonNode` to extract the 'table' field.*
   
   ## Brief change log
   
     - *Deserialization of `CanalJsonDeserializationSchema` should firstly deserialize message to `JsonNode` to extract the 'table' field for table filter.*
   
   ## Verifying this change
   
     - *Add the test binlog record to `canal-data-filter-table.txt` to verfiy the test case `testFilteringTables` in `CanalJsonSerDeSchemaTest`.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997) 
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041",
       "triggerID" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5adfea8032e4ed53eb1e30f3d864f08271389a8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041",
       "triggerID" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027) 
   * da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035) 
   * 5adfea8032e4ed53eb1e30f3d864f08271389a8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041",
       "triggerID" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027) 
   * da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035) 
   * 5adfea8032e4ed53eb1e30f3d864f08271389a8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c530c839776b2dea354b836d88671bca2f650a5c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985) 
   * 6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759932673


   @wuchong , thanks for your detailed review. I have updated `deserialize(...)` to reuse the following two methods. Please help to review again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759848185


   @wuchong , please help to review this bugfix for the deserialization of Canal JSON format.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14631:
URL: https://github.com/apache/flink/pull/14631#discussion_r557038157



##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -113,6 +113,36 @@ public RowData deserialize(@Nullable byte[] message) throws IOException {
         }
     }
 
+    public JsonNode deserializeToJsonNode(@Nullable byte[] message) throws IOException {

Review comment:
       Could you update `deserialize(..)` to reuse these two method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c530c839776b2dea354b836d88671bca2f650a5c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759376320


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c530c839776b2dea354b836d88671bca2f650a5c (Wed Jan 13 11:04:41 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027) 
   * da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997) 
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041",
       "triggerID" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035) 
   * 5adfea8032e4ed53eb1e30f3d864f08271389a8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12041) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759965317


   There are failed tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759376320


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5adfea8032e4ed53eb1e30f3d864f08271389a8b (Fri May 28 07:07:44 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] SteNicholas commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759973593


   @wuchong , sorry for my mistake to change the behavior message of throwing exception. I have updated the `deserialize(...)` method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14631:
URL: https://github.com/apache/flink/pull/14631


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c530c839776b2dea354b836d88671bca2f650a5c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985) 
   * 6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c530c839776b2dea354b836d88671bca2f650a5c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c530c839776b2dea354b836d88671bca2f650a5c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14631:
URL: https://github.com/apache/flink/pull/14631#issuecomment-759388845


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11985",
       "triggerID" : "c530c839776b2dea354b836d88671bca2f650a5c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11997",
       "triggerID" : "6d9cb1f0126e86b640d2775f0a3b1bc20d2821e9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018",
       "triggerID" : "e283ba5376620acf27777206a9c9ff7a4cdc9ba9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027",
       "triggerID" : "571a38f52edb662a2b5c8a157ef96a52ad5ddb68",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035",
       "triggerID" : "da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5adfea8032e4ed53eb1e30f3d864f08271389a8b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e283ba5376620acf27777206a9c9ff7a4cdc9ba9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12018) 
   * 571a38f52edb662a2b5c8a157ef96a52ad5ddb68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12027) 
   * da3e25fe1e5fa5031be6ba0ddacc4a27fefeacd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12029) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12035) 
   * 5adfea8032e4ed53eb1e30f3d864f08271389a8b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org