You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/02 20:23:00 UTC
[GitHub] [commons-text] orionlibs opened a new pull request, #440: refactored the append method by splitting it
orionlibs opened a new pull request, #440:
URL: https://github.com/apache/commons-text/pull/440
refactored the append method, because it handles padding, truncation, and formatting. It would be better to split these into separate methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEXT-226: refactored the append method by splitting it [commons-text]
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #440:
URL: https://github.com/apache/commons-text/pull/440#issuecomment-1837483381
this PR has been open for half a year
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] garydgregory commented on pull request #440: TEXT-226: refactored the append method by splitting it
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #440:
URL: https://github.com/apache/commons-text/pull/440#issuecomment-1736006662
There is no use case IMO. What do others think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] orionlibs commented on pull request #440: TEXT-226: refactored the append method by splitting it
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #440:
URL: https://github.com/apache/commons-text/pull/440#issuecomment-1735966866
this PR was done 70 days ago. It awaits review and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEXT-226: refactored the append method by splitting it [commons-text]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #440:
URL: https://github.com/apache/commons-text/pull/440#issuecomment-1837486108
I don't see the need for this. Change for the sake of change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEXT-226: refactored the append method by splitting it [commons-text]
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs closed pull request #440: TEXT-226: refactored the append method by splitting it
URL: https://github.com/apache/commons-text/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org