You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/24 18:47:50 UTC

[GitHub] [incubator-gobblin] ibuenros commented on a change in pull request #2637: [GOBBLIN-772]Implement Schema Comparison Strategy during Disctp

ibuenros commented on a change in pull request #2637: [GOBBLIN-772]Implement Schema Comparison Strategy during Disctp
URL: https://github.com/apache/incubator-gobblin/pull/2637#discussion_r287475457
 
 

 ##########
 File path: gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
 ##########
 @@ -936,4 +936,10 @@
   public static final String GIT_MONITOR_SSH_KNOWN_HOSTS = "knownHosts";
   public static final String GIT_MONITOR_SSH_KNOWN_HOSTS_FILE = "knownHostsFile";
   public static final String GIT_MONITOR_JSCH_LOGGER_ENABLED = "isJschLoggerEnabled";
+
+  /**
+   * Configuration related to data derived
 
 Review comment:
   Please adjust the comment so it makes sense in Gobblin itself. This is leaking LinkedIn implementation details.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services