You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/11/02 08:45:47 UTC
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/838
TAJO-1954: Fix memory leak in physical operator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #838
----
commit 356a07dcab9d8205c04b9774e6137432c1c3dbc7
Author: Jinho Kim <jh...@apache.org>
Date: 2015-11-02T07:44:51Z
TAJO-1954: Fix memory leak in physical operator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/838#discussion_r43711383
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java ---
@@ -172,6 +168,13 @@ public void close() throws IOException {
@Override
public void init() throws IOException {
+ super.init();
+
+ if (aggregateExecs != null) {
--- End diff --
PhysicalPlannerImpl.createSortAggregationDistinctGroupbyExec always set the array, so it can not occurs NPE.
Next time, I will refactor these code.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/838
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on a diff in the pull request:
https://github.com/apache/tajo/pull/838#discussion_r43616625
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java ---
@@ -172,6 +168,13 @@ public void close() throws IOException {
@Override
public void init() throws IOException {
+ super.init();
+
+ if (aggregateExecs != null) {
--- End diff --
@jinossy I have a question? Do we need check null check for aggregateExecs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/838#issuecomment-152969407
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/838#discussion_r43707748
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java ---
@@ -172,6 +168,13 @@ public void close() throws IOException {
@Override
public void init() throws IOException {
+ super.init();
+
+ if (aggregateExecs != null) {
--- End diff --
@charsyam
I refer to close() but It seems to the unnecessary checking. Are you working on this operator ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1954: Fix memory leak in physical operator...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on a diff in the pull request:
https://github.com/apache/tajo/pull/838#discussion_r43709328
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java ---
@@ -172,6 +168,13 @@ public void close() throws IOException {
@Override
public void init() throws IOException {
+ super.init();
+
+ if (aggregateExecs != null) {
--- End diff --
@jinossy I'm sorry.
I tested below code. and it causes NPE.
```java
List<String> lists = null;
for(String a : lists) {
}
```
I think null checking is needed. sorry to disturb you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---