You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/07/29 21:59:44 UTC

[GitHub] [storm] srdo commented on a change in pull request #3095: STORM-3478: Upgrade to JUnit 5.5.1 and Mockito 3.0.0

srdo commented on a change in pull request #3095: STORM-3478: Upgrade to JUnit 5.5.1 and Mockito 3.0.0
URL: https://github.com/apache/storm/pull/3095#discussion_r308455865
 
 

 ##########
 File path: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutMessagingGuaranteeTest.java
 ##########
 @@ -90,8 +90,6 @@ public void testAtMostOnceModeCommitsBeforeEmit() throws Exception {
 
         spout.nextTuple();
 
-        when(consumerMock.position(partition)).thenReturn(1L);
 
 Review comment:
   Just for context, these are unused stubs, which Mockito complains about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services