[GitHub] [solr] dsmiley commented on a change in pull request #261: SOLR-15428: Fix forbiddenapis Gradle setup. Also fix java options to …

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #261:
URL: https://github.com/apache/solr/pull/261#discussion_r688073420



##########
File path: solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java
##########
@@ -31,7 +30,7 @@
 
   @Before
   public void setup() {
-    System.setProperty("randomSeed", Long.toString(new Random().nextLong()));
+    System.setProperty("randomSeed", Long.toString(random().nextLong()));

Review comment:
       Too bad `com.carrotsearch.randomizedtesting.RandomizedContext#getRunnerSeed` isn't public but any way it's not a big deal; the change here is fine.  `com.carrotsearch.randomizedtesting.RandomizedContext#getRunnerSeedAsString` is public but it's hex.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org