You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/04 05:15:56 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #7165: Attach names for all producers/readers in worker service

jerrypeng commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r434997005



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -91,6 +91,7 @@ public void initialize() {
             Reader<byte[]> reader = pulsarClient.newReader()
                     .topic(this.workerConfig.getFunctionMetadataTopic())
                     .startMessageId(MessageId.earliest)
+                    .readerName(workerConfig.getWorkerId() + "-function-metadata-manager")

Review comment:
       I don't know if its needed to add "-function-metadata-manager".  I would say that this information as a property e.g. component: function-metadata-manager but properties is not exposed for the reader




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org