You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/27 14:15:39 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6148: arch/xtensa: Refactor assembly macros

xiaoxiang781216 commented on code in PR #6148:
URL: https://github.com/apache/incubator-nuttx/pull/6148#discussion_r859854635


##########
arch/xtensa/src/common/xtensa_panic.S:
##########
@@ -147,14 +129,7 @@ _xtensa_panic:
 
 	/* Set up PS for C, re-enable hi-pri interrupts, and clear EXCM. */
 
-#ifdef __XTENSA_CALL0_ABI__
-	movi	a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM
-#else
-	movi	a0, PS_INTLEVEL(XCHAL_EXCM_LEVEL) | PS_UM | PS_WOE
-#endif
-
-	wsr		a0, PS
-	rsync
+  ps_setup XCHAL_EXCM_LEVEL a0

Review Comment:
   not alignment here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org