You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/02/05 02:46:24 UTC

[PR] Load: Trigger last flush time map & tsfile resource degrading after successful load [iotdb]

SteveYurongSu opened a new pull request, #12024:
URL: https://github.com/apache/iotdb/pull/12024

   ## Description
   
   After loading about 1_200_000 files into the storage engine, the system threw OOM exception.
   
   After careful check, it was found that the current load tsfile operation does not trigger the last flush time map & tsfile resource degrading.
   
   ![img_v3_027l_1a6ddaed-b927-49f5-a7bb-8274715e9f4g](https://github.com/apache/iotdb/assets/30497621/cb079acc-882a-41a7-b44c-f4ed967ff306)
   
   ![img_v3_027o_b8422e4d-ea51-424d-b01f-4e3cfecec0eg](https://github.com/apache/iotdb/assets/30497621/1d48a31d-18f9-44d9-b802-58bc2973dc64)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Load: Trigger last flush time map & tsfile resource degrading after successful load [iotdb]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12024:
URL: https://github.com/apache/iotdb/pull/12024#issuecomment-1926181667

   ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `16 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`8c90117`)](https://app.codecov.io/gh/apache/iotdb/commit/8c90117ebc551cd1bda30537245221431d9fef4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.16% compared to head [(`9a6563d`)](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.16%.
   
   | [Files](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../iotdb/db/storageengine/dataregion/DataRegion.java](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3RvcmFnZWVuZ2luZS9kYXRhcmVnaW9uL0RhdGFSZWdpb24uamF2YQ==) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12024      +/-   ##
   ============================================
   - Coverage     49.16%   49.16%   -0.01%     
   + Complexity    26160    26159       -1     
   ============================================
     Files          2943     2943              
     Lines        184507   184519      +12     
     Branches      22140    22142       +2     
   ============================================
   + Hits          90716    90720       +4     
   - Misses        93791    93799       +8     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/12024?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Load: Trigger last flush time map & tsfile resource degrading after successful load [iotdb]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12024:
URL: https://github.com/apache/iotdb/pull/12024#issuecomment-1926145318

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12024) **Quality Gate failed**  
   Failed conditions
   
   [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12024&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12024)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Load: Trigger last flush time map & tsfile resource degrading after successful load [iotdb]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12024:
URL: https://github.com/apache/iotdb/pull/12024#issuecomment-1926151653

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12024) **Quality Gate failed**  
   Failed conditions
   
   [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=12024&metric=new_coverage&view=list) (required ≥ 80%)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=12024)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Load: Trigger last flush time map & tsfile resource degrading after successful load [iotdb]

Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #12024:
URL: https://github.com/apache/iotdb/pull/12024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org