You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/21 08:59:15 UTC
[GitHub] [spark] lipzhu opened a new pull request #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
lipzhu opened a new pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666
### What changes were proposed in this pull request?
In the PR, I add the nameOfCorruptRecord parameter to the JsonToStructs expression.
### Why are the changes needed?
This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By JsonExpressionsSuite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592825123
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23855/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593735063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23937/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592908728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119112/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593734658
**[Test build #119197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119197/testReport)** for PR 27666 at commit [`af74851`](https://github.com/apache/spark/commit/af748517b4c54d01e35cb64332d75c4b5a9eef04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589563451
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-597459033
Closing this per the discussion in the JIRA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589563845
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589586450
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589563451
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590204620
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587252
**[Test build #118779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118779/testReport)** for PR 27666 at commit [`56e1e9e`](https://github.com/apache/spark/commit/56e1e9ebfee3bab0bdd4f7557f83386681f8e96b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592959742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119122/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590165955
**[Test build #118844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118844/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593797423
**[Test build #119197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119197/testReport)** for PR 27666 at commit [`af74851`](https://github.com/apache/spark/commit/af748517b4c54d01e35cb64332d75c4b5a9eef04).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592959742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119122/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589563845
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592825123
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23855/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589706307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118779/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587971
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589706307
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118779/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592825109
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592959555
**[Test build #119122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119122/testReport)** for PR 27666 at commit [`50d1408`](https://github.com/apache/spark/commit/50d14088b7237f57df1d09ddccfe6a84997f71a3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592822750
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592824618
**[Test build #119112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119112/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#discussion_r386550812
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
##########
@@ -559,7 +567,6 @@ case class JsonToStructs(
(rows: Iterator[InternalRow]) => if (rows.hasNext) rows.next().getMap(0) else null
}
- val nameOfCorruptRecord = SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD)
Review comment:
`nameOfCorruptRecord` is used only in `parser` below. I would try to move it there:
```scala
@transient lazy val parser = {
val parsedOptions = new JSONOptions(
options,
timeZoneId.get,
SQLConf.get.getConf(SQLConf.COLUMN_NAME_OF_CORRUPT_RECORD))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593735057
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590204627
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118844/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590166178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23592/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593798116
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592908421
**[Test build #119112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119112/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590204627
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118844/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590166178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23592/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589706297
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#discussion_r382497137
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
##########
@@ -604,6 +608,20 @@ case class JsonToStructs(
override def prettyName: String = "from_json"
}
+object JsonToStructs{
Review comment:
@lipzhu Please run the linter `./dev/lint-scala` and fix the style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592908725
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587971
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592936817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592908725
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593798121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119197/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593798121
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119197/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590166175
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592959741
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590165955
**[Test build #118844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118844/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590166175
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592936820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23864/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23531/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589704904
**[Test build #118779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118779/testReport)** for PR 27666 at commit [`56e1e9e`](https://github.com/apache/spark/commit/56e1e9ebfee3bab0bdd4f7557f83386681f8e96b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592936817
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592825109
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593735063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23937/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589586495
cc @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593735057
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592959741
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592936820
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23864/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590204445
**[Test build #118844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118844/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592937293
**[Test build #119122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119122/testReport)** for PR 27666 at commit [`50d1408`](https://github.com/apache/spark/commit/50d14088b7237f57df1d09ddccfe6a84997f71a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587977
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23531/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-590204620
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592908728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119112/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589706297
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-589587252
**[Test build #118779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118779/testReport)** for PR 27666 at commit [`56e1e9e`](https://github.com/apache/spark/commit/56e1e9ebfee3bab0bdd4f7557f83386681f8e96b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593798116
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27666: [SPARK-30896]:The
behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-593734658
**[Test build #119197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119197/testReport)** for PR 27666 at commit [`af74851`](https://github.com/apache/spark/commit/af748517b4c54d01e35cb64332d75c4b5a9eef04).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592937293
**[Test build #119122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119122/testReport)** for PR 27666 at commit [`50d1408`](https://github.com/apache/spark/commit/50d14088b7237f57df1d09ddccfe6a84997f71a3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27666:
[SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27666: [SPARK-30896]:The behavior of JsonToStructs should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27666#issuecomment-592824618
**[Test build #119112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119112/testReport)** for PR 27666 at commit [`7228cb0`](https://github.com/apache/spark/commit/7228cb01b1be644e7ea4e1c0e9b3381b86e6bfaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org