You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2006/11/24 05:06:39 UTC
[PATCH] Test cleanup: use None instead of "" constistently
Several files in the test suite use the run_and_verify_svn method
extensively, but argument usage is inconsistent. The first argument can
be either "" or None, with no functional change. Prior to applying this
patch, the usage of None far outweighs the usage of "". This patch
changes the python tests to use None instead of "" when appropriate for
run_and_verify_svn.
-Hyrum
[[[
Update the tests to consistently use None as the first argument when
calling run_and_verify_svn.
* subversion/tests/cmdline/revert_tests.py
* subversion/tests/cmdline/log_tests.py
* subversion/tests/cmdline/trans_tests.py
* subversion/tests/cmdline/externals_tests.py
* subversion/tests/cmdline/copy_tests.py
* subversion/tests/cmdline/svnversion_tests.py
* subversion/tests/cmdline/special_tests.py
* subversion/tests/cmdline/basic_tests.py
* subversion/tests/cmdline/utf8_tests.py
* subversion/tests/cmdline/commit_tests.py
* subversion/tests/cmdline/authz_tests.py
Change calls to svntest.actions.run_and_verify_svn to use None instead
of "" when not expecting a message.
]]]
Re: [PATCH] Test cleanup: use None instead of "" constistently
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Daniel Rall wrote:
> Hyrum, the patch looks good. Please commit it to trunk (noting "dlr"
> as the approver).
Thanks! Done in r22464.
-Hyrum
> On Thu, 23 Nov 2006, Hyrum K. Wright wrote:
>
>> Several files in the test suite use the run_and_verify_svn method
>> extensively, but argument usage is inconsistent. The first argument can
>> be either "" or None, with no functional change. Prior to applying this
>> patch, the usage of None far outweighs the usage of "". This patch
>> changes the python tests to use None instead of "" when appropriate for
>> run_and_verify_svn.
>>
>> -Hyrum
>>
>> [[[
>> Update the tests to consistently use None as the first argument when
>> calling run_and_verify_svn.
>>
>> * subversion/tests/cmdline/revert_tests.py
>> * subversion/tests/cmdline/log_tests.py
>> * subversion/tests/cmdline/trans_tests.py
>> * subversion/tests/cmdline/externals_tests.py
>> * subversion/tests/cmdline/copy_tests.py
>> * subversion/tests/cmdline/svnversion_tests.py
>> * subversion/tests/cmdline/special_tests.py
>> * subversion/tests/cmdline/basic_tests.py
>> * subversion/tests/cmdline/utf8_tests.py
>> * subversion/tests/cmdline/commit_tests.py
>> * subversion/tests/cmdline/authz_tests.py
>> Change calls to svntest.actions.run_and_verify_svn to use None instead
>> of "" when not expecting a message.
>> ]]]
Re: [PATCH] Test cleanup: use None instead of "" constistently
Posted by Daniel Rall <dl...@collab.net>.
Hyrum, the patch looks good. Please commit it to trunk (noting "dlr"
as the approver).
- Dan
On Thu, 23 Nov 2006, Hyrum K. Wright wrote:
> Several files in the test suite use the run_and_verify_svn method
> extensively, but argument usage is inconsistent. The first argument can
> be either "" or None, with no functional change. Prior to applying this
> patch, the usage of None far outweighs the usage of "". This patch
> changes the python tests to use None instead of "" when appropriate for
> run_and_verify_svn.
>
> -Hyrum
>
> [[[
> Update the tests to consistently use None as the first argument when
> calling run_and_verify_svn.
>
> * subversion/tests/cmdline/revert_tests.py
> * subversion/tests/cmdline/log_tests.py
> * subversion/tests/cmdline/trans_tests.py
> * subversion/tests/cmdline/externals_tests.py
> * subversion/tests/cmdline/copy_tests.py
> * subversion/tests/cmdline/svnversion_tests.py
> * subversion/tests/cmdline/special_tests.py
> * subversion/tests/cmdline/basic_tests.py
> * subversion/tests/cmdline/utf8_tests.py
> * subversion/tests/cmdline/commit_tests.py
> * subversion/tests/cmdline/authz_tests.py
> Change calls to svntest.actions.run_and_verify_svn to use None instead
> of "" when not expecting a message.
> ]]]