You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "tballison (via GitHub)" <gi...@apache.org> on 2025/07/14 19:08:08 UTC
[PR] TIKA-1997 -- initial poc, derived from rob975's work on: https://github.com/apache/tika/pull/267 [tika]
tballison opened a new pull request, #2281:
URL: https://github.com/apache/tika/pull/2281
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
* the issue ID (`TIKA-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square brackets (`[TIKA-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Tika is successfully built and unit tests pass by running `mvn clean test`
* there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch
* if you add new module that downstream users will depend upon add it to relevant group in `tika-bom/pom.xml`.
We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-1997 -- initial poc, derived from rob975's work on: https://github.com/apache/tika/pull/267 [tika]
Posted by "rob975 (via GitHub)" <gi...@apache.org>.
rob975 commented on PR #2281:
URL: https://github.com/apache/tika/pull/2281#issuecomment-3079149912
After 6 years without feedback I dropped the fork, hence closing the PR.
Hope your PR gets merged.
The tests commented out rely on content inspection like it used to be done for XML files. Idk if it can still be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-1997 -- initial poc, derived from rob975's work on: https://github.com/apache/tika/pull/267 [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #2281:
URL: https://github.com/apache/tika/pull/2281#issuecomment-3426273493
Life got in the way. :rofl:
Other key issue is that I'm not sure I'm doing the right thing to differentiate the different subtypes after I have the asn1 objects.
@marcelstoer if my hackery looks good to you, we can merge this in main and 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-1997 -- initial poc, derived from rob975's work on: https://github.com/apache/tika/pull/267 [tika]
Posted by "marcelstoer (via GitHub)" <gi...@apache.org>.
marcelstoer commented on PR #2281:
URL: https://github.com/apache/tika/pull/2281#issuecomment-3425003702
This is referenced in https://issues.apache.org/jira/browse/TIKA-3784 (years long discussion). That's how I found here. What are the reasons for this to be labeled as draft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org