You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ma...@apache.org on 2026/04/08 10:59:29 UTC
(cordova-plugin-inappbrowser) 01/01: chore(ios): remove pre ios 11 code in `show:withNoAnimate:`
This is an automated email from the ASF dual-hosted git repository.
manuelbeck pushed a commit to branch pr-chore-ios-remove-pre-ios-11-code-in-show-withNoAnimate
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git
commit 43bc4e472a3dadc334175a812a4dc74af43343d4
Author: Manuel Beck <ma...@outlook.de>
AuthorDate: Wed Apr 8 12:59:16 2026 +0200
chore(ios): remove pre ios 11 code in `show:withNoAnimate:`
- The plugin supports minimum iOS 11
---
src/ios/CDVWKInAppBrowser.m | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/ios/CDVWKInAppBrowser.m b/src/ios/CDVWKInAppBrowser.m
index 71c1c9a..cce5502 100644
--- a/src/ios/CDVWKInAppBrowser.m
+++ b/src/ios/CDVWKInAppBrowser.m
@@ -241,7 +241,6 @@
// Run later to avoid the "took a long time" log message.
dispatch_async(dispatch_get_main_queue(), ^{
if (weakSelf.inAppBrowserViewController != nil) {
- float osVersion = [[[UIDevice currentDevice] systemVersion] floatValue];
__strong __typeof(weakSelf) strongSelf = weakSelf;
if (!strongSelf->tmpWindow) {
if (@available(iOS 13.0, *)) {
@@ -269,9 +268,6 @@
// window would never be displayed, which results in a white/blank screen.
if (!strongSelf->tmpWindow) {
CGRect frame = [[UIScreen mainScreen] bounds];
- if (initHidden && osVersion < 11) {
- frame.origin.x = -10000;
- }
strongSelf->tmpWindow = [[UIWindow alloc] initWithFrame:frame];
}
}
@@ -279,7 +275,7 @@
[strongSelf->tmpWindow setRootViewController:tmpController];
[strongSelf->tmpWindow setWindowLevel:UIWindowLevelNormal];
- if (!initHidden || osVersion < 11) {
+ if (!initHidden) {
[self->tmpWindow makeKeyAndVisible];
}
[tmpController presentViewController:nav animated:!noAnimate completion:nil];
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org