You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/04/09 21:16:14 UTC
Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/
-----------------------------------------------------------
Review request for drill, Hanifi Gunes and Mehant Baid.
Repository: drill-git
Description
-------
Please see DRILL-2685 for details.
Diffs
-----
pom.xml 8c9f09e
Diff: https://reviews.apache.org/r/33030/diff/
Testing
-------
Ran concurrent tests by setting forkCount > 1
Thanks,
Venki Korukanti
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79581
-----------------------------------------------------------
initial set of comments
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129058>
We should make this class a singleton instead of declaring variables static.
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129059>
This logic should be moved into factory method after singleton refactoring.
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129060>
unneeded after singleton refac (I think)
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129045>
Use java.nio.Files.createTempFile instead of this method.
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129063>
let's not mark these methods static as the class will be singleton and we will have one & only one instance either way. Else, I would recommend moving all sub-related convenience methods to a utility class for keeping class members cohesive.
- Hanifi Gunes
On April 9, 2015, 7:16 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 7:16 p.m.)
>
>
> Review request for drill, Hanifi Gunes and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see DRILL-2685 for details.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
>
> Diff: https://reviews.apache.org/r/33030/diff/
>
>
> Testing
> -------
>
> Ran concurrent tests by setting forkCount > 1
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79754
-----------------------------------------------------------
Ship it!
Ship It!
- Mehant Baid
On April 10, 2015, 1:40 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:40 a.m.)
>
>
> Review request for drill, Hanifi Gunes and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see DRILL-2685 for details.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java 1c7e16d
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java 14ab506
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
>
> Diff: https://reviews.apache.org/r/33030/diff/
>
>
> Testing
> -------
>
> Ran concurrent tests by setting forkCount > 1
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79624
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On April 10, 2015, 1:40 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 1:40 a.m.)
>
>
> Review request for drill, Hanifi Gunes and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see DRILL-2685 for details.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java 1c7e16d
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java 14ab506
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
>
> Diff: https://reviews.apache.org/r/33030/diff/
>
>
> Testing
> -------
>
> Ran concurrent tests by setting forkCount > 1
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/
-----------------------------------------------------------
(Updated April 10, 2015, 1:40 a.m.)
Review request for drill, Hanifi Gunes and Mehant Baid.
Repository: drill-git
Description
-------
Please see DRILL-2685 for details.
Diffs (updated)
-----
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java 1c7e16d
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java 14ab506
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
Diff: https://reviews.apache.org/r/33030/diff/
Testing
-------
Ran concurrent tests by setting forkCount > 1
Thanks,
Venki Korukanti
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/#review79609
-----------------------------------------------------------
close to shipping.
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java
<https://reviews.apache.org/r/33030/#comment129107>
We should avoid heavy initialization in c'tor. We can delegate functionality to a init method and call it in getInst.
- Hanifi Gunes
On April 10, 2015, 12:22 a.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33030/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:22 a.m.)
>
>
> Review request for drill, Hanifi Gunes and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see DRILL-2685 for details.
>
>
> Diffs
> -----
>
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java 1c7e16d
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java 14ab506
> contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
>
> Diff: https://reviews.apache.org/r/33030/diff/
>
>
> Testing
> -------
>
> Ran concurrent tests by setting forkCount > 1
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/
-----------------------------------------------------------
(Updated April 10, 2015, 12:22 a.m.)
Review request for drill, Hanifi Gunes and Mehant Baid.
Changes
-------
addressed review comments.
Repository: drill-git
Description
-------
Please see DRILL-2685 for details.
Diffs (updated)
-----
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestBase.java 1c7e16d
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java a76128f
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/sql/hive/TestViewSupportOnHiveTables.java 14ab506
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
Diff: https://reviews.apache.org/r/33030/diff/
Testing
-------
Ran concurrent tests by setting forkCount > 1
Thanks,
Venki Korukanti
Re: Review Request 33030: DRILL-2685: Unique-ify local Hive metastore
directory per test JVM
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33030/
-----------------------------------------------------------
(Updated April 9, 2015, 7:16 p.m.)
Review request for drill, Hanifi Gunes and Mehant Baid.
Changes
-------
uploading the actual patch.
Repository: drill-git
Description
-------
Please see DRILL-2685 for details.
Diffs (updated)
-----
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java 657da61
Diff: https://reviews.apache.org/r/33030/diff/
Testing
-------
Ran concurrent tests by setting forkCount > 1
Thanks,
Venki Korukanti