You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/07/31 13:03:28 UTC

Review Request 61255: Stomp connections leak on ambari-agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61255/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21616
    https://issues.apache.org/jira/browse/AMBARI-21616


Repository: ambari


Description
-------

Connections get leaked on ambari-agent leading to high CPU usage after agent
running for couple of days. This is caused by not closed connection threads.

The reason for this is race condition in ambari_stomp as well as incorrect
handing of exceptions during connection initialization


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py ab24bb4 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py fb73d6d 
  ambari-common/src/main/python/ambari_stomp/adapter/websocket.py e672a70 
  ambari-common/src/main/python/ambari_stomp/transport.py d497d6a 


Diff: https://reviews.apache.org/r/61255/diff/1/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk