[GitHub] [spark] KevinSmile commented on a change in pull request #29653: [SPARK-32804][Launcher] Fix run-example command builder bug

[GitBox <gi...@apache.org>]

KevinSmile commented on a change in pull request #29653:
URL: https://github.com/apache/spark/pull/29653#discussion_r484180285



##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
##########
@@ -241,9 +241,11 @@
     }
 
     args.addAll(parsedArgs);
+
     if (appResource != null) {
       args.add(appResource);

Review comment:
       When you do `run-example`,  you just specify the class name(e.g. SparkPi),  and no need to specify the app-jar. So in backend code, `appResource` should be auto-find-and-set as the examples' main app jar (e.g. `./examples/jars/spark-examples_2.12-3.0.0.jar`), and then be added as an arg ( this arg will later be set as the so-called `primaryResource`).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org